Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] 다중 메뉴 position것만 들어가게 수정 완료!! #79

Merged
merged 1 commit into from
Nov 8, 2023
Merged

[FIX] 다중 메뉴 position것만 들어가게 수정 완료!! #79

merged 1 commit into from
Nov 8, 2023

Conversation

HI-JIN2
Copy link
Member

@HI-JIN2 HI-JIN2 commented Nov 7, 2023

개요

meadId로 세부 메뉴 조회하는 API를 사용해서 리팩토링함.

  • 이전 방식: 홈화면에서 메뉴 리스트의 이름과 ID를 두 개의 리스트로 만들어서 넘겼는데
  • 변경된 방식: API 호출해서 바로 바인딩 하는 방법으로 변경

@HI-JIN2 HI-JIN2 linked an issue Nov 7, 2023 that may be closed by this pull request
[FIX] 다중메뉴에 그 position으로 안들어감 #78
Closed
@HI-JIN2 HI-JIN2 self-assigned this Nov 7, 2023
@HI-JIN2 HI-JIN2 requested a review from Amepistheo November 7, 2023 09:37
Amepistheo
Amepistheo approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@Amepistheo Amepistheo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요!!

@HI-JIN2 HI-JIN2 merged commit efd823e into main Nov 8, 2023
1 check passed
@HI-JIN2 HI-JIN2 deleted the 78-fix-mealID-position branch November 8, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amepistheo Amepistheo Amepistheo approved these changes

Assignees

@HI-JIN2 HI-JIN2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] 다중메뉴에 그 position으로 안들어감
2 participants
@HI-JIN2 @Amepistheo