[FEAT] update review #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
… 53-feat-update-review # Conflicts: # app/src/main/java/com/eatssu/android/adapter/FixedMenuAdapter.kt # app/src/main/java/com/eatssu/android/view/review/ReviewListActivity.kt
… 53-feat-update-review # Conflicts: # app/src/main/AndroidManifest.xml # app/src/main/java/com/eatssu/android/adapter/TodayMealAdapter.kt
… 53-feat-update-review
…tSSU-Android into 53-feat-update-review
HI-JIN2
approved these changes
Nov 7, 2023
HI-JIN2
reviewed
Nov 7, 2023
| @@ -143,13 +140,17 @@ class MainActivity : AppCompatActivity() { | |||
|
|
|||
| calendarAdapter = CalendarAdapter(calendarList) | |||
|
|
|||
| val viewModel = ViewModelProvider(this@MainActivity)[CalendarViewModel::class.java] | |||
There was a problem hiding this comment.
오앙 이거 뷰모델 생성 위치 변경으로 처음 진입시 오늘 날짜 인식하게 되는 원리(?)인가용?? 신기신기
There was a problem hiding this comment.
앗 그건 아니구 처음 접근 했을 때 오늘 날짜 viewmodel에 넣으려면 위에서 작업해야 돼서 올렸습니당!
HI-JIN2
reviewed
Nov 9, 2023
Comment on lines
+66
to
+67
| val service = mRetrofit.create(ReviewService::class.java) | ||
|
|
There was a problem hiding this comment.
요기 mRetrofit은 멀티파트용 레트로핏 객체입니다! 리뷰 수정의 경우, 멀티파트 폼이 아닌 json형식으로 저희 일반 토큰 있는 레트로핏을 사용해야해요! 420 뜨던데, 이게 문제였던 것 같음요
HI-JIN2
reviewed
Nov 9, 2023
| Toast.makeText(this@MyReviewDialogActivity, "리뷰 삭제가 취소되었습니다", Toast.LENGTH_SHORT).show() | ||
| }) | ||
| setPositiveButton("삭제", DialogInterface.OnClickListener { dialog, which -> | ||
| val service = mRetrofit.create(ReviewService::class.java) |
There was a problem hiding this comment.
요기도 일반 토큰 있는 레트로핏 객체 불러다 호출하면 될겁니당
HI-JIN2
reviewed
Nov 9, 2023
Comment on lines
+16
to
+28
| <!-- <TextView--> | ||
| <!-- android:id="@+id/tv_eat_ssu"--> | ||
| <!-- android:layout_width="match_parent"--> | ||
| <!-- android:layout_height="80dp"--> | ||
| <!-- android:text="리뷰 남기기"--> | ||
| <!-- android:gravity="center"--> | ||
| <!-- android:textSize="25dp"--> | ||
| <!-- android:textColor="@color/white"--> | ||
| <!-- android:textStyle="bold"--> | ||
| <!-- android:background="@color/main"--> | ||
| <!-- app:layout_constraintEnd_toEndOf="parent"--> | ||
| <!-- app:layout_constraintStart_toStartOf="parent"--> | ||
| <!-- app:layout_constraintTop_toTopOf="parent" />--> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업 사항
스크린샷 및 작동 영상