-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation for v3.0.0 release #925
Conversation
- Add `sphinx-copybutton` extension for markdown formatted as code - Add `docs-verisoned` command to `Makefile`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @chengzhuzhang, this PR to update documentation is now ready for review. The description lists the summary of changes. Thank you!
docs/source/index.rst
Outdated
**ARM diags**, and **TC analysis** are implemented in v2 release. v3 introduces a | ||
completely new back-end, replacing CDAT with Xarray and xCDAT. Due to the significant | ||
scale of code changes, this has been incremented as a major release. The user-facing | ||
API for running E3SM Diagnostics remains backward-compatible between v2 and v3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added new section to Current State describing v3.
docs/source/install.rst
Outdated
(a) Latest Stable Release | ||
------------------------- | ||
|
||
1. Follow :ref:`"Others/Local" <conda_environment_others>` section for installing Conda. | ||
|
||
2. Get the yml file to create an environment. | ||
|
||
:: | ||
|
||
wget https://raw.githubusercontent.com/E3SM-Project/e3sm_diags/main/conda-env/prod.yml | ||
|
||
|
||
3. Change ``prefix`` in that file to be your conda prefix. Typically, this will be ``~/miniconda3/envs/e3sm_diags_env``. | ||
1. Follow :ref:`"Others/Local" <conda_environment_others>` section for installing conda. | ||
|
||
4. Remove any cached conda packages. This will ensure that you always get the latest packages | ||
Create a new conda environment with ``e3sm_diags`` installed and activate it: | ||
|
||
:: | ||
|
||
mamba clean --all | ||
|
||
5. Use conda to create a new environment with E3SM Diags (``e3sm_diags``) included. | ||
These steps should not be necessary if you installed Mambaforge as suggested | ||
above but may be needed if you have previously installed Miniconda3 instead: :: | ||
|
||
conda install -y -n base mamba | ||
conda config --add channels conda-forge | ||
conda config --set channel_priority strict | ||
|
||
Create a new conda environment with ``e3sm_diags`` installed and activate it: :: | ||
|
||
mamba env create -f conda-env/prod.yml # Tip: Add the flag ``-n <name_of_env>`` to customize the name of the environment | ||
# Tip: Add the flag ``-n <name_of_env>`` to customize the name of the environment | ||
conda create -n e3sm_diags_env e3sm_diags | ||
conda activate e3sm_diags_env | ||
|
||
.. _dev-env: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace the "a) Latest Stable Release" section with just creating a fresh conda env with latest stable e3sm_diags
.
### Major refactor with v3 development | ||
|
||
v3.0.0 marks a major milestone after nearly two years of work by the core development | ||
team. This release introduces a completely new back-end, replacing CDAT with Xarray and | ||
xCDAT. Due to the significant scale of code changes, this has been incremented as a | ||
major release. The user-facing API for running E3SM Diagnostics remains backward-compatible between v2 and v3. | ||
|
||
The modernization improves performance, usability, and maintainability, paving the way | ||
for future enhancements to E3SM development. The refactored codebase is now more robust | ||
and extensively covered by unit tests, setting a solid foundation for ongoing testing and development. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added new section to Current State describing v3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great write up.
@chengzhuzhang I think we just have this PR and PR #953 (soon to be merged) before we can release v3.0.0. Let me know if you need additional help here. I think this PR covers most of the changes already. |
### New Feature added during v2 development | ||
|
||
| Feature name <br />(set name) | Brief Introduction | Developers Contributors\* | Released version | | ||
| ------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | --------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ---------------- | | ||
| Added Qbo wavelet analysis (qbo) | The spectrum analysis in the QBO dataset was enhanced with an additional wavelet-based analysis | Justine richling , Walter Hannah, Jim Benedict | 2.12.1 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added v2.12.1 feature change
@@ -149,7 +151,7 @@ Additional back-ends could be implemented if the need arose. | |||
+--------------------------------------------------------+------------------------------------------------------+ | |||
|
|||
The above plots and more can be found | |||
`here <https://portal.nersc.gov/cfs/e3sm/zhang40/tutorials/run_v230_allsets/viewer/>`_. | |||
`here <https://portal.nersc.gov/cfs/e3sm/chengzhu/tutorial2024/e3sm_diags_extended/viewer/>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update to use the 2024 tutorial example.
|
||
1. Follow :ref:`"Others/Local" <conda_environment_others>` section for installing conda. | ||
|
||
2. Clone your fork and keep it in sync with the main repo's ``main`` | ||
2. Create a new fork of e3sm_diags: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simplify this session.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some more updates.
Description
This pull request includes several changes to the documentation and dependencies, along with updates to the installation and usage instructions. The most important changes include the addition of a new Sphinx extension, updates to the documentation to reflect the new version, and the removal of outdated references.
Documentation Updates:
README.md
: Added a section about the major refactor in version 3, highlighting the transition from CDAT to Xarray and xCDAT.docs/source/index.rst
: Updated the version number from v2 to v3 and removed outdated warnings and references. [1] [2]Dependency Changes:
conda-env/ci.yml
andconda-env/dev.yml
: Addedsphinx-copybutton
to the list of dependencies. [1] [2]Configuration Changes:
docs/source/conf.py
: Addedsphinx_copybutton
to the list of Sphinx extensions.docs/source/conf.py
: Removed thehtml_theme_path
setting.Makefile
: Adddocs-versioned
command to generate docs usingsphinx-multiversion
Installation Instructions:
docs/source/install.rst
: Updated instructions for downloading and installing Miniforge instead of Mambaforge. Removed references to the outdatedacme1
machine and updated the conda environment creation commands. [1] [2] [3] [4]mamba
section back toconda
since conda now useslibmamba
as default solver #821Removal of Outdated References:
docs/source/quickguides/generate_quick_guides.py
: Removed references toacme1
machine. [1] [2]docs/source/quickguides/index.rst
: Removed the quick guide foracme1
.docs/source/quickguides/old/index.rst
: Removed old quick guides for version 1./docs/source/examples.rst
: Updatesalloc
reference for perlmutterTODO
Checklist
If applicable: