Fixes for the A-grid dycore, removal of coupler hydrostasis, and improvement of coupler error messages #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mrnorman
commented
Sep 20, 2023
mrnorman
commented
- Adding -DPAMA_DYCORE when A-grid dycore is specified in CMake.
- New A-grid dycore that uses SSPRK3, hydrostatically balanced gravity, and better boundary vertical conditions (isentropically constant).
- More informative error messages for the coupler, DataManager, and Options classes.
- Removing hydrostasis from the coupler.
- Adding gcm_cloud_water and gcm_cloud_ice to the coupler's default allocated state and setting to zero in the mmf_simplified driver.
- Removing duplicate -DPAM_RAD= from A-grid cmakescript.sh.
- Adding dycore.declare_current_profile_as_hydrostatic( coupler , true ) to the mmf_simplified driver for the A-grid dycore
…grid dycore that uses SSPRK3, hydrostatically balanced gravity, and better boundary vertical conditions (isentropically constant). More informative error messages for the coupler, DataManager, and Options classes. Removing hydrostasis from the coupler. Adding gcm_cloud_water and gcm_cloud_ice to the coupler's default allocated state and setting to zero in the mmf_simplified driver. Removing duplicate -DPAM_RAD= from A-grid cmakescript.sh. Adding dycore.declare_current_profile_as_hydrostatic( coupler , true ) to the mmf_simplified driver for the A-grid dycore
mwarusz
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.