EAMxx: simplify branch runs and adding new output streams #7063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly and automatically avoid the restart of any output stream
bartgol
added
BFB
bartgol
commented
Feb 26, 2025
| @@ -217,6 +217,7 @@ class AtmosphereDriver | |||
| util::TimeStamp m_run_t0; | |||
| util::TimeStamp m_case_t0; | |||
| RunType m_run_type; | |||
| bool m_branch_run = false; | |||
There was a problem hiding this comment.
I thought about adding a new value to RunType, but it required a few more changes across the library. Maybe that's more appropriate though?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify workflow for branch runs, and, in general, runs where new output streams are added upon restart.
[BFB]
Right now, for branch runs, the user needs to add the entry
Perform Restart: falseentry in theRestartsublist of their output yaml file. This allows EAMxx to skip the look for the rhist file. However, the user must later remove this entry, so that upon subsequent restarts the stream IS restarted. This is confusing, and may be overlooked.This PR automatically handles this kind of details. In particular:
Perform Restart: falsewithskip_restart_if_rhist_not_found: true. This makes it simpler, since this param does not need to be removed after the 1st "post-restart-run"