Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAMxx: Set the defaults for flushing output files #7009

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AaronDonahue
Copy link
Contributor

Temporary fix to an issue in the EAMxx I/O that can cause some output files to be missing or overwritten. This commit sets the default flush frequency to 1 and forces a new file to be opened for output after every restart.

[BFB]

@AaronDonahue AaronDonahue added BFB PR leaves answers BFB EAMxx PRs focused on capabilities for EAMxx labels Feb 13, 2025
@AaronDonahue AaronDonahue requested a review from bartgol February 13, 2025 18:19
@AaronDonahue
Copy link
Contributor Author

@crterai , this PR should set the defaults for restart frequency.

Copy link
Contributor

@bartgol bartgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit tests for output restart need to be modified, as they ASSUME there will be a single output file. For those, you much set force_new_file to false.

Temporary fix to an issue in the EAMxx I/O that can cause some
output files to be missing or overwritten.  This commit sets the default
flush frequency to 1 and forces a new file to be opened for output after
every restart.

[BFB]
@AaronDonahue AaronDonahue force-pushed the aarondonahue/eamxx/set_io_flush_defaults branch from 0b686fe to efddbc2 Compare February 20, 2025 22:30
@AaronDonahue AaronDonahue requested a review from bartgol February 20, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB EAMxx PRs focused on capabilities for EAMxx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants