[WIP] Get cached image path with source uri #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #557 +/- ##
========================================
+ Coverage 94.11% 95% +0.88%
========================================
Files 1 1
Lines 17 20 +3
========================================
+ Hits 16 19 +3
Misses 1 1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #557 +/- ##
==========================================
+ Coverage 94.73% 95.00% +0.26%
==========================================
Files 1 1
Lines 19 20 +1
==========================================
+ Hits 18 19 +1
Misses 1 1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new static method
getCachePaththat takes image source uri and returns a promise of its cached file path. If the image has not been stored in cache, it returnsnull.I've only done the iOS part, haven't done Android and haven't updated the docs. I probably won't have the time to finish this any time soon. But if someone wants to contribute to this feature, you can base it off my changes.
Solves #293.