Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert windows tests and benchmarks #230

Merged
merged 2 commits into from
Feb 1, 2025

Conversation

Dwlad90
Copy link
Owner

@Dwlad90 Dwlad90 commented Feb 1, 2025

Pull Request Template

Description

Downgrade node to working version. The error with ERR_INVALID_URL is part of the latest version of node: 22.13.1, 20.18.2 and 18.20.6. So can revert tests and benchmarks on Windows

Type of change

Please select options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • I have read the CONTRIBUTING document

@Dwlad90 Dwlad90 force-pushed the revert-windows-tests-and-benchmarks branch 5 times, most recently from 8e4d6f9 to 6d3dfaa Compare February 1, 2025 21:14
Downgrade node to working version. The error with ERR_INVALID_URL is part of the latest version of
node: 22.13.1, 20.18.2 and 18.20.6. So can revert tests and benchmarks on Windows
@Dwlad90 Dwlad90 force-pushed the revert-windows-tests-and-benchmarks branch from 1961a39 to dcaf015 Compare February 1, 2025 21:39
@Dwlad90
Copy link
Owner Author

Dwlad90 commented Feb 1, 2025

/approve

@Dwlad90
Copy link
Owner Author

Dwlad90 commented Feb 1, 2025

/merge

Copy link
Contributor

github-actions bot commented Feb 1, 2025

Success! Fast forwarded develop to revert-windows-tests-and-benchmarks!

@github-actions github-actions bot merged commit dcaf015 into develop Feb 1, 2025
5 checks passed
@github-actions github-actions bot deleted the revert-windows-tests-and-benchmarks branch February 1, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant