Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stylex_path_resolver): export field resolution with multiple node_modules in a workspace #224

Merged

Conversation

Dwlad90
Copy link
Owner

@Dwlad90 Dwlad90 commented Jan 23, 2025

Pull Request Template

Description

This PR fix export field resolution with multiple nested node_modules in a workspace

Fixes

(Optional) Issu #223

Type of change

Please select options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • I have read the CONTRIBUTING document

@Dwlad90 Dwlad90 force-pushed the fix-export-field-resolution-with-multiple-workspace branch from 22a49fc to 8a7c3f6 Compare January 23, 2025 22:27
@Dwlad90 Dwlad90 force-pushed the fix-export-field-resolution-with-multiple-workspace branch from 8a7c3f6 to 4ede850 Compare January 23, 2025 22:28
@Dwlad90
Copy link
Owner Author

Dwlad90 commented Jan 23, 2025

/approve

@Dwlad90
Copy link
Owner Author

Dwlad90 commented Jan 23, 2025

/merge

Copy link
Contributor

Success! Fast forwarded develop to fix-export-field-resolution-with-multiple-workspace!

@github-actions github-actions bot merged commit 4ede850 into develop Jan 23, 2025
5 checks passed
@github-actions github-actions bot deleted the fix-export-field-resolution-with-multiple-workspace branch January 23, 2025 22:33
@Dwlad90 Dwlad90 temporarily deployed to release-approval January 23, 2025 22:34 — with GitHub Actions Inactive
@Dwlad90 Dwlad90 temporarily deployed to changlog-approval January 23, 2025 22:36 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant