-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add path logger #222
Add path logger #222
Conversation
2f39e33
to
bcf7e60
Compare
Hi @mattstyles, thanks for the PR, great job. It really does look a bit noisy, but I think the debugging value outweighs that. It's probably worth printing out potentially valid import paths for StyleX files in Something like this: debug!("Resolved file paths: {:?} for import `{}`", valid_file_paths, import_path_str); |
b7de6b3
to
77c00a3
Compare
/merge |
Success! Fast forwarded develop to add-path-logger! |
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Adds debug logging to rs-compiler based on the value of the environment variable
STYLEX_DEBUG
. If this env variable does not exist (or does not match the log levels below) then no log information will be output (same behaviour as now).Log levels supported:
I have only added a few log instances to rs-compiler as I'm not sure on which areas are going to be most valuable.
Logs in this diff show which files are being traversed, and provides information on the resolved import path from the list of potential valid import paths.
Additional Info
I've added an info log and some debug logs regarding pathing of stylex imports.
Type of change
Please select options that are relevant.
Checklist: