Skip to content

Commit

Permalink
ci(npm): run tests and benchmarks on node v22.13.0
Browse files Browse the repository at this point in the history
Downgrade node to working version. The error with ERR_INVALID_URL is part of the latest version of
node: 22.13.1, 20.18.2 and 18.20.6. So can revert tests and benchmarks on Windows
  • Loading branch information
Dwlad90 committed Feb 1, 2025
1 parent 01a889d commit d0a2ad6
Show file tree
Hide file tree
Showing 7 changed files with 28 additions and 24 deletions.
4 changes: 2 additions & 2 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"image": "mcr.microsoft.com/devcontainers/base:ubuntu",
"features": {
"ghcr.io/devcontainers/features/node:1": {
"version": "20.17.0",
"pnpmVersion": "9.9.0"
"version": "22.13.0",
"pnpmVersion": "9.15.4"
},
"ghcr.io/devcontainers/features/rust:1": {
"version": "1.82.0",
Expand Down
4 changes: 2 additions & 2 deletions .github/actions/setup-pnpm/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ runs:
name: Install pnpm
id: pnpm-install
with:
version: 9.9.0
version: 9.15.4

- uses: actions/setup-node@v4
name: Install Node.js
with:
node-version: 20.17.0
node-version: 22.13.0
cache: 'pnpm'

- name: Install dependencies
Expand Down
34 changes: 19 additions & 15 deletions .github/workflows/npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
docker: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-debian-aarch64
build: pnpm run --filter @stylexswc/rs-compiler build --target aarch64-unknown-linux-gnu
node:
- '20'
- '22.13.0'
name: 🛠️ Build - ${{ matrix.settings.target }} - node@${{ matrix.settings.target }}
runs-on: ${{ matrix.settings.host }}
steps:
Expand Down Expand Up @@ -91,18 +91,19 @@ jobs:
fail-fast: false
matrix:
settings:
# - host: windows-latest
# target: x86_64-pc-windows-msvc
# architecture: x64
- host: windows-latest
target: x86_64-pc-windows-msvc
architecture: x64
- host: macos-latest
target: aarch64-apple-darwin
architecture: arm64
- host: macos-latest
target: x86_64-apple-darwin
architecture: x64
node:
- '18'
- '20'
- '18.20.5'
- '20.18.1'
- '22.13.0'
runs-on: ${{ matrix.settings.host }}
steps:
- name: Enable long path support
Expand Down Expand Up @@ -137,8 +138,9 @@ jobs:
fail-fast: false
matrix:
node:
- '18'
- '20'
- '18.20.5'
- '20.18.1'
- '22.13.0'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -173,8 +175,9 @@ jobs:
fail-fast: false
matrix:
node:
- '18'
- '20'
- '18.20.5'
- '20.18.1'
- '22.13.0'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -209,9 +212,9 @@ jobs:
fail-fast: false
matrix:
settings:
# - host: windows-latest
# target: x86_64-pc-windows-msvc
# architecture: x64
- host: windows-latest
target: x86_64-pc-windows-msvc
architecture: x64
- host: macos-latest
target: aarch64-apple-darwin
architecture: arm64
Expand All @@ -222,8 +225,9 @@ jobs:
target: x86_64-unknown-linux-gnu
architecture: x64
node:
- '18'
- '20'
- '18.20.5'
- '20.18.1'
- '22.13.0'
runs-on: ${{ matrix.settings.host }}
permissions:
contents: write
Expand Down
2 changes: 1 addition & 1 deletion .npmrc
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ auto-install-peers=true
dedupe-peer-dependents=true
engine-strict=true
link-workspace-packages=deep
node-version=20.17.0
node-version=22.13.0
prefer-workspace-packages=true
resolve-peers-from-workspace-root=true
save-workspace-protocol=rolling
Expand Down
2 changes: 1 addition & 1 deletion crates/stylex-rs-compiler/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
]
}
},
"packageManager": "pnpm@9.9.0",
"packageManager": "pnpm@9.15.4",
"private": false,
"publishConfig": {
"registry": "https://registry.npmjs.org/",
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@
"url": "https://github.com/dwlad90/stylex-swc-plugin"
},
"engines": {
"node": ">=20.17.0"
"node": ">=22.13.0"
},
"packageManager": "pnpm@9.9.0",
"packageManager": "pnpm@9.15.4",
"pnpm": {
"overrides": {
"webpack@<5.0.0": "^5.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/unplugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@stylexswc/unplugin",
"type": "module",
"version": "0.6.4-rc.1",
"packageManager": "pnpm@9.9.0",
"packageManager": "pnpm@9.15.4",
"description": "Unplugin for StyleX RS compiler",
"license": "MIT",
"private": false,
Expand Down

0 comments on commit d0a2ad6

Please sign in to comment.