Blockly: fix movement blocks with integrated counter #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cagix
changed the title
|
@b-franklin Hast Du den PR grad vom Produs-Projekt hier rüber gestellt? Hmmm. @AMatutat Wir sollten nochmal über die Workflows sprechen imho. An sich passt das hier konkret eigentlich gut, die Fixes "drüben" im Fork zu implementieren und dann hier zum Mergen rüberzureichen. Das klappt aber nur, solange der Fork auch immer synchron ist - was auf Dauer aber nicht der Fall sein wird. |
|
lgtm, good job |
AMatutat
approved these changes
Jan 17, 2025
dann los :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed names of field_number fields of Movement blocks to "amount" #1673
fixes #1673