Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes calrissian #181 #186

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

fabricebrito
Copy link
Collaborator

@fabricebrito fabricebrito commented Dec 13, 2024

This PR adds command line interface options to set network access pod labels.

Then CWL CLT that specify the NetworkAccess requirement will run pods labelled according to the calrissian command-line values set.

The implementation of the cluster network policies is of course out of the scope of calrissian. Without network policies, you only get labelled pods, nothing else :-)

These labels can thus be defined in NetworkPolicies to control the pod egress based on the CWL NetworkAccess requirement introduced in v1.1.

@fabricebrito
Copy link
Collaborator Author

This also carries a few enhancements:

  • drops support for Python 3.8
  • adds support for Python 3.13
  • updates cwltool to 3.1.20250110105449

@fabricebrito fabricebrito marked this pull request as ready for review January 16, 2025 09:23
@emmanuelmathot emmanuelmathot self-requested a review January 24, 2025 14:41
Copy link
Collaborator

@emmanuelmathot emmanuelmathot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not test the network policy on kubernetes but all tests seem to cover the new arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants