[BUG] MPCTEMP settings missing in Configuration.h

[skkayman]

Did you test the latest Molise code ?

Yes, and the problem still exists.

Bug Description

When I uncomment MPCTEMP (and comment PIDTEMP out), build will fails because of missing parameters for MPC.

Bug Timeline

No response

Expected behavior

Add missing settings (MPC_HEATER_POWER, MPC_BLOCK_HEAT_CAPACITY, MPC_SENSOR_RESPONSIVENESS, ...) or remove the line where MPCTEMP can be set/DEFINE.

Actual behavior

Build fails

Steps to Reproduce

1. Comment #define PIDTEMP
2. Uncomment #define MPCTEMP
3. Build

Version of Molise or Marlin Firmware

4.0 / 2.1.1-bugfix

Printer model

Hornet

Electronics

No response

Add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

• A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

Marlin\src\module\settings.cpp: In static member function 'static void MarlinSettings::reset()':
Marlin\src\module\settings.cpp:3362:43: error: 'MPC_HEATER_POWER' was not declared in this scope
3362 | constexpr float _mpc_heater_power[] = MPC_HEATER_POWER;
| ^~~~~~~~~~~~~~~~
Marlin\src\module\settings.cpp:3363:50: error: 'MPC_BLOCK_HEAT_CAPACITY' was not declared in this scope
3363 | constexpr float _mpc_block_heat_capacity[] = MPC_BLOCK_HEAT_CAPACITY;
| ^~~~~~~~~~~~~~~~~~~~~~~
Marlin\src\module\settings.cpp:3364:52: error: 'MPC_SENSOR_RESPONSIVENESS' was not declared in this scope
3364 | constexpr float _mpc_sensor_responsiveness[] = MPC_SENSOR_RESPONSIVENESS;
| ^~~~~~~~~~~~~~~~~~~~~~~~~Compiling .pio\build\hornet\src\src\sd\SdFatUtil.cpp.o

Marlin\src\module\settings.cpp:3365:49: error: 'MPC_AMBIENT_XFER_COEFF' was not declared in this scope
3365 | constexpr float _mpc_ambient_xfer_coeff[] = MPC_AMBIENT_XFER_COEFF;
| ^~~~~~~~~~~~~~~~~~~~~~
Marlin\src\module\settings.cpp:3369:55: error: 'FILAMENT_HEAT_CAPACITY_PERMM' was not declared in this scope
3369 | constexpr float _filament_heat_capacity_permm[] = FILAMENT_HEAT_CAPACITY_PERMM;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
*** [.pio\build\hornet\src\src\module\settings.cpp.o] Error 1
Marlin\src\module\temperature.cpp: In destructor 'Temperature::MPC_autotune()::OnExit::~OnExit()':
Marlin\src\module\temperature.cpp:926:24: error: 'MPC_TUNING_END_Z' was not declared in this scope
926 | do_z_clearance(MPC_TUNING_END_Z);
| ^~~~~~~~~~~~~~~~
Marlin\src\module\temperature.cpp: In member function 'void Temperature::MPC_autotune()':
Marlin\src\module\temperature.cpp:943:33: error: 'MPC_TUNING_POS' was not declared in this scope
943 | const xyz_pos_t tuningpos = MPC_TUNING_POS;
| ^~~~~~~~~~~~~~
Marlin\src\module\temperature.cpp:976:30: error: 'MPC_MAX' was not declared in this scope; did you mean 'TMP_MAX'?
976 | hotend.soft_pwm_amount = MPC_MAX >> 1;
| ^~~~~~~
| TMP_MAX
Marlin\src\module\temperature.cpp:1017:15: error: 'struct MPC_t' has no member named 'fan255_adjustment'
1017 | constants.fan255_adjustment = 0.0f;
| ^~~~~~~~~~~~~~~~~
Marlin\src\module\temperature.cpp:1076:17: error: 'struct MPC_t' has no member named 'fan255_adjustment'
1076 | constants.fan255_adjustment = ambient_xfer_coeff_fan255 - constants.ambient_xfer_coeff_fan0;
| ^~~~~~~~~~~~~~~~~
compilation terminated due to -fmax-errors=5.
*** [.pio\build\hornet\src\src\module\temperature.cpp.o] Error 1``
configurations.zip