Development for v0.1.5 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed lint exclusions for deprecated "extraction_operator_linter" (lintr v3.2.0) - [condition_call_linter] Use stop(., call. = FALSE) not to display the call in an error message. - [matrix_apply_linter] Use rowSums(.) rather than apply(., 1, sum) - [indentation_linter] Indentation should be 6 spaces but is 4 spaces. - [unnecessary_lambda_linter] Pass rowSums directly as a symbol to vapply() instead of wrapping it in an unnecessary anonymous function. - [paste_linter] Use paste(), not paste0(), to collapse a character vector when sep= is not used. - [print_linter] Use cat() instead of print() logging messages. Use message() in cases calling for a signalled condition. - [implicit_assignment_linter] Avoid implicit assignments in function calls.
- check_depth_table() now returns additionally vectors of sites with ** mismatched profile depth ** mismatched counts of soil layers ** discontinuities in soil layer depths ** non-monotonic increasing soil layer depths
Update GHAs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
- Coverage 88.24% 88.10% -0.15%
==========================================
Files 7 7
Lines 723 891 +168
==========================================
+ Hits 638 785 +147
- Misses 85 106 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.