Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes and make the project compile with ocaml 5.1 #16

Closed
wants to merge 3 commits into from
Closed

Small fixes and make the project compile with ocaml 5.1 #16

wants to merge 3 commits into from

Conversation

FardaleM
Copy link
Collaborator

@FardaleM FardaleM commented Nov 20, 2023 •
edited
Loading

This is a collection of small fixes that I have found so far.

  • add the dependency to the project to be able to opam install it
  • correct the compilation with ocaml 5.1 because of change in the compiler libs
  • correct the implementation of subset in the bitvector implementation

@FardaleM
Copy link
Collaborator Author

It is still not compiling, don't merge.

@FardaleM
Copy link
Collaborator Author

FardaleM commented Nov 20, 2023 •
edited
Loading

Now, it compiles, but the second commit needs to be checked.

@FardaleM FardaleM changed the title Small fixes to make the project compile with ocaml 5.1 Small fixes and make the project compile with ocaml 5.1 Nov 20, 2023
@FardaleM
fix: add missing dependencies
855b06d
@FardaleM
fix: adapt to the change of Outcometree.out_type.Otyp_alias
b670487
@FardaleM
fix(Bitv): fix the is_subset function
2f40f77 
in a bit vector, given two set i and b, testing "(i && b) <> 0" is
testing if the intersection is non-empty and not if i is a subset of b.
@FardaleM FardaleM closed this Dec 14, 2023
@Drup Drup deleted the fix branch July 15, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FardaleM