Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] add tradable symbols test #2858

Merged
merged 1 commit into from
Jan 13, 2025
Merged

[Tests] add tradable symbols test #2858

merged 1 commit into from
Jan 13, 2025

Conversation

GuillaumeDSM
Copy link
Member

@GuillaumeDSM GuillaumeDSM self-assigned this Jan 12, 2025
@GuillaumeDSM GuillaumeDSM requested a review from Herklos as a code owner January 12, 2025 14:57
Herklos
Herklos approved these changes Jan 12, 2025
View reviewed changes
Copy link
Member

@Herklos Herklos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

additional_tests/exchanges_tests/abstract_authenticated_exchange_tester.py
@@ -104,6 +106,8 @@ class AbstractAuthenticatedExchangeTester:
CHECK_EMPTY_ACCOUNT = False # set True when the account to check has no funds. Warning: does not check order
# parse/create/fill/cancel or portfolio & trades parsing
IS_BROKER_ENABLED_ACCOUNT = True # set False when this test account can't generate broker fees
# set True when this exchange used to have symbols that can't be traded through API (ex: MEXC)
USED_TO_HAVE_UNTRADABLE_SYMBOL = False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

additional_tests/exchanges_tests/abstract_authenticated_exchange_tester.py
all_tickers = await self.exchange_manager.exchange.get_all_currencies_price_ticker()
assert all_tickers[first_untradable_symbol][trading_enums.ExchangeConstantsTickersColumns.CLOSE.value] > 0
# Orders
# try creating & cancelling orders on 5 random tradable and untradable symbols
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GuillaumeDSM GuillaumeDSM enabled auto-merge (rebase) January 13, 2025 08:23
@GuillaumeDSM GuillaumeDSM merged commit 10b3a31 into dev Jan 13, 2025
14 checks passed
@GuillaumeDSM GuillaumeDSM deleted the tradable branch January 13, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Herklos Herklos Herklos approved these changes

Assignees

@GuillaumeDSM GuillaumeDSM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeDSM @Herklos