Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest name #2839

Merged
merged 2 commits into from
Dec 29, 2024
Merged

Rest name #2839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d40d484
[Tests] update futures tests
GuillaumeDSM Dec 29, 2024
043132c
[Requirements] bump
GuillaumeDSM Dec 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions additional_tests/exchanges_tests/abstract_authenticated_exchange_tester.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,14 @@ async def test_get_portfolio_with_market_filter(self):
# check portfolio fetched with filtered markets (should be equal to the one with all markets)
filtered_markets_portfolio = await self.get_portfolio()
if self.EXPECT_BALANCE_FILTER_BY_MARKET_STATUS:
assert filtered_markets_portfolio == {
filtered = {
key: val
for key, val in all_markets_portfolio.items()
if key in symbols.parse_symbol(self.SYMBOL).base_and_quote()
}
assert filtered_markets_portfolio == filtered, f"{filtered_markets_portfolio=} != {filtered=}"
else:
assert filtered_markets_portfolio == all_markets_portfolio
assert filtered_markets_portfolio == all_markets_portfolio, f"{filtered_markets_portfolio=} != {all_markets_portfolio=}"

async def inner_test_get_portfolio(self):
self.check_portfolio_content(await self.get_portfolio())
Expand Down
6 changes: 2 additions & 4 deletions additional_tests/exchanges_tests/test_binance_futures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@ async def test_get_portfolio(self):
await super().test_get_portfolio()

async def test_get_portfolio_with_market_filter(self):
# pass if not implemented
pass
await super().test_get_portfolio_with_market_filter() # can have small variations failing the test when positions are open

async def test_get_account_id(self):
await super().test_get_account_id()
Expand All @@ -59,8 +58,7 @@ async def test_invalid_api_key_error(self):
await super().test_invalid_api_key_error()

async def test_get_api_key_permissions(self):
# pass if not implemented
pass
await super().test_get_api_key_permissions()

async def test_missing_trading_api_key_permissions(self):
pass
Expand Down
4 changes: 2 additions & 2 deletions additional_tests/exchanges_tests/test_kucoin_futures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@ class TestKucoinFuturesAuthenticatedExchange(
EXPECT_MISSING_FEE_IN_CANCELLED_ORDERS = False
IS_AUTHENTICATED_REQUEST_CHECK_AVAILABLE = True # set True when is_authenticated_request is implemented
EXPECTED_QUOTE_MIN_ORDER_SIZE = 40
EXPECT_BALANCE_FILTER_BY_MARKET_STATUS = True

async def test_get_portfolio(self):
await super().test_get_portfolio()

async def test_get_portfolio_with_market_filter(self):
# pass if not implemented
pass
await super().test_get_portfolio_with_market_filter() # can have small variations failing the test when positions are open

async def test_get_account_id(self):
await super().test_get_account_id()
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Drakkar-Software requirements
OctoBot-Commons==1.9.70
OctoBot-Trading==2.4.138
OctoBot-Trading==2.4.139
OctoBot-Evaluators==1.9.7
OctoBot-Tentacles-Manager==2.9.16
OctoBot-Services==1.6.21
Expand Down
Loading