[Grid] add trailing option #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeDSM
changed the title
Herklos
reviewed
Jan 19, 2025
Comment on lines
+227
to
+228
| self.CONFIG_ENABLE_TRAILING_UP: False, | ||
| self.CONFIG_ENABLE_TRAILING_DOWN: False, |
There was a problem hiding this comment.
trailing up could be true by default indeed.
However, trailing down will sell at a loss, I don't think it should be true by default
There was a problem hiding this comment.
Do you think we should enable it by default ? I would say no but we create a default profile with a trailing grid instead
There was a problem hiding this comment.
That's a good idea (only for trailing UP I think)
There was a problem hiding this comment.
Yes, only trailing up, i'll add it
| await asyncio.create_task(_check_open_orders_count(exchange_manager, producer.operational_depth - 1)) # -1 because the very first order can't be at a price <0 | ||
| # orders are recreated around 125 | ||
| _check_created_orders(producer, trading_api.get_open_orders(exchange_manager), 125) | ||
| # now contains buy and sell orders |
GuillaumeDSM
force-pushed
the
trailing
branch
from
cd1637b to
afd7036
Compare
Herklos
reviewed
Jan 22, 2025
| @@ -1655,6 +1655,81 @@ async def test_order_notification_callback(): | |||
| _lock_portfolio_and_create_order_when_possible.assert_called_once() | |||
|
|
|||
|
|
|||
| async def test_create_mirror_order(): | |||
GuillaumeDSM
force-pushed
the
trailing
branch
from
08c2b0a to
cb88979
Compare
|
up with profile |
Herklos
approved these changes
Jan 24, 2025
| _generate_staggered_orders_mock.assert_awaited_once_with(price, ignore_available_funds, trigger_trailing) | ||
| _create_not_virtual_orders_mock.assert_awaited_once_with([], price, True) | ||
|
|
||
| # already trailing: skip call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires Drakkar-Software/OctoBot-Trading#1170