-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't open TimePickerModal on click time-picker-preview #1
Comments
I know what you mean, but actually I just want to toggle the modal when clicking on the preview panel. I think it's reasonable. |
Maybe I could make this behavior configurable. 😃 |
Mmm. Maybe i don't understand. But u live demo (https://domonji.github.io/vue-clock-picker/) work prefect as need, and click on preview panel -> toggle modal with clock. But version on master branch and npm package don't toggle modal with clock by click on preview panel. P.S. if need, i can create version with autoswitch from hour to minutes on choose hour, and close modal on choose minutes, and add pull request. |
That's strange. I remember I built this live demo with master branch. It would be very nice if you add pull requests. |
Don't open modal becourse click on time-picker run two function: toggleFocus() and onClearFocus() becourse element OutsideClickHandler catch this click as outside click. toggleFocus() - open modal then onClearFocus() close modal.
I think need add overElement data for TimePicker(), add
@mouseover="overElement=true" @mouseout="overElement=false"
to time-picker-preview,and change onClearFocus() to:
The text was updated successfully, but these errors were encountered: