@QueryParam with null, how to deal with it?

[natros]

I have this get method

@GET
List<TemplateDto> getTemplates(
    @QueryParam("categoriaId") @Nullable Integer categoriaId,
    @QueryParam("tipo") List<TipoTemplate> tipos,
    @QueryParam("hidden") boolean hidden,
    @QueryParam("zero") boolean zero,
    @QueryParam("ts") long ts);

that generates

  public ServerRequest<Void, List<TemplateDto>> getTemplates(Integer categoriaId,
      List<TipoTemplate> tipos, boolean hidden, boolean zero, long ts) {
    TemplatesResource_getTemplates instance = new TemplatesResource_getTemplates();
    instance.setQueryParameter("categoriaId", instance.emptyOrStringValue(() -> categoriaId));
    instance.setQueryParameter("tipo", instance.emptyOrStringValue(() -> tipos));
    instance.setQueryParameter("hidden", instance.emptyOrStringValue(() -> hidden));
    instance.setQueryParameter("zero", instance.emptyOrStringValue(() -> zero));
    instance.setQueryParameter("ts", instance.emptyOrStringValue(() -> ts));
    return instance;
  }

and creates URL
http://localhost:7021/docs/api/templates?categoriaId=&tipo=[PRINCIPAL,%20SECUNDARIO]&hidden=false&zero=false&ts=1615035551000

The problem is that RestEasy cannot convert '' to Integer

RESTEASY003870: Unable to extract parameter from http request: javax.ws.rs.QueryParam("categoriaId") value is '' for public abstract java.util.List pt.ipb.gdoc2.shared.api.TemplatesResource.getTemplates(java.lang.Integer,java.util.List,boolean,boolean,long)

RestyGWT generates a different URL that omits null parameters
http://localhost:7021/docs/api/templates?zero=false&tipo=PRINCIPAL&tipo=SECUNDARIO&hidden=false&ts=1615036682000

Do you have any advice in this case?

[vegegoku]

Do wr have any specifications in this regard with jax-rs or should we implement our own solution?

[natros]

BTW, RestEasy cannot handle type=[ENUM1, ENUM2] for lists. RestyGwt translates to type=ENUM1&type=ENUM2

@QueryParam("type") List<TemplateTypes> types

where TemplateTypes is an enum { ENUM1, ENUM2}

Do you want me to create issues for both cases?

[vegegoku]

Spring on the other hand works with the comma-separated style, so this also should be a configuration, Yes please an issue will be awesome and thank you for the feedback 👍

[natros]

Done #66 and #67

About spring. I'm not spring user, but after reading this, it seems that spring supports url?phone=123&phone=345 and url?phone=123,345 but I did not find the pattern url?phone=[123,345]

[natros]

If you go this route to set up the configuration, maybe the more appropriate place is the annotation @RequestFactory

If you don't want to have too many configuration parameters in @RequestFactory, you can always implement something like @RequestFactory(config = MyRequestConf.class) where MyRequestConf could be described as

@RequestFactoryConfig (option1 = ..., option2 = ..., optionN = ...)
public interface MyRequestConf {}

[vegegoku]

If you go this route to set up the configuration, maybe the more appropriate place is the annotation @RequestFactory

If you don't want to have too many configuration parameters in @RequestFactory, you can always implement something like @RequestFactory(config = MyRequestConf.class) where MyRequestConf could be described as

@RequestFactoryConfig (option1 = ..., option2 = ..., optionN = ...)
public interface MyRequestConf {}

I think we are going to utilize the https://github.com/DominoKit/domino-rest/blob/development/domino-rest-client/src/main/java/org/dominokit/rest/DominoRestConfig.java for the global configurations

for overriding the behavior for the specific interface we will go with new annotations.