Qual: Fix phan notices in api classes #33311
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdeweerd
force-pushed
the
fix/qual/api
branch
2 times, most recently
from
f8abbcc to
3d01287
Compare
|
With this PR all files have been reviewed for notices visible in cti.dolibarr.org . The PhanTypeMismatchArgument and PhanTypeMismatchArgumentNull notices still have about 1200 and 300 cases to review in about 400 files. However files from htdocs/hrm onwards (in the alphabet) are already reviewed for these (33 PhanTypeMismatchArgument* notices remaining). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qual: Fix phan notices in api classes
Fixes most notices in API classes - the remaining notices require more analysis.