-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New/group fetch and fetch optionals #33257
base: develop
Are you sure you want to change the base?
New/group fetch and fetch optionals #33257
Conversation
…irvine/dolibarr into NEW/GROUP_FETCH_AND_FETCH_OPTIONALS
@eldy @atm-irvine the sql function "ST_AsWKT()" is not compatible with Postgresql no ? |
@hregis This function is available if you activate an option on PostgreSQL, apparently. Since it was already in the core, I took the liberty of taking it. |
@atm-irvine are you talking about PostGIS? If yes the name of the function is not the same : https://postgis.net/docs/ST_AsEWKT.html
Maybe the better is to use ST_AsText https://postgis.net/docs/ST_AsText.html
And what happens if PostGIS can not be installed? Thanks |
@eldy What do you think about that ? |
@hregis Tbh I don't know. I just took the code.. Eldy will tell us what to do |
@eldy it's possible to check if PostGIS is enabled with "PostGIS_Version()" maybe add a specific function in sql drivers for this to avoid errors ? |
NEW|New group classic fetch and fetch optionals depending on conf
I've grouped classic fetch and fetch optionals to prevent doing multiple sql requests for the same result. For invoice and its lines. All of this depends on MAIN_DO_FETCH_IN_ONE_SQL_REQUEST conf.
Once this PR is merged, I'll do it for every document.