Skip to content

Commit

Permalink
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 21.0
Browse files Browse the repository at this point in the history
  • Loading branch information
eldy committed Mar 3, 2025
2 parents 259f8f5 + 2843597 commit fd970b5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions htdocs/core/class/html.formsetup.class.php
Original file line number Diff line number Diff line change
Expand Up @@ -706,10 +706,10 @@ public function loadValueFromConf()
{
global $conf;
if (isset($conf->global->{$this->confKey})) {
$this->fieldValue = getDolGlobalString($this->confKey);
$this->fieldValue = getDolGlobalString($this->confKey, null);

Check failure on line 709 in htdocs/core/class/html.formsetup.class.php

View workflow job for this annotation

GitHub Actions / phpstan / php-stan (8.2)

Parameter #2 $default of function getDolGlobalString expects float|int|string, null given.

Check warning on line 709 in htdocs/core/class/html.formsetup.class.php

View workflow job for this annotation

GitHub Actions / phan / Run phan

html.formsetup.class.php: PhanTypeMismatchArgumentProbablyReal: Argument 2 ($default) is null of type null but \getDolGlobalString() takes float|int|string (no real type) defined at htdocs/core/lib/functions.lib.php:228 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

Check warning on line 709 in htdocs/core/class/html.formsetup.class.php

View workflow job for this annotation

GitHub Actions / phan / Run phan

html.formsetup.class.php: PhanTypeMismatchArgumentProbablyReal: Argument 2 ($default) is null of type null but \getDolGlobalString() takes float|int|string (no real type) defined at htdocs/core/lib/functions.lib.php:228 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

Check failure on line 709 in htdocs/core/class/html.formsetup.class.php

View workflow job for this annotation

GitHub Actions / phpstan / php-stan (8.2)

Parameter #2 $default of function getDolGlobalString expects float|int|string, null given.
return true;
} else {
$this->fieldValue = '';
$this->fieldValue = null;
return false;
}
}
Expand Down
1 change: 1 addition & 0 deletions htdocs/core/modules/facture/doc/pdf_crabe.modules.php
Original file line number Diff line number Diff line change
Expand Up @@ -1359,6 +1359,7 @@ protected function _tableau_info(&$pdf, $object, $posy, $outputlangs, $outputlan

$langs->loadLangs(array('payment', 'paybox', 'stripe'));
$servicename = $langs->transnoentities('Online');

$paiement_url = getOnlinePaymentUrl(0, 'invoice', $object->ref, 0, '', 0);
$linktopay = $langs->trans("ToOfferALinkForOnlinePayment", $servicename).' <a href="'.$paiement_url.'">'.$outputlangs->transnoentities("ClickHere").'</a>';

Expand Down

0 comments on commit fd970b5

Please sign in to comment.