Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create automatic docker build when pushing to github #132

Open
silkroadnomad opened this issue Feb 25, 2020 · 19 comments
Open

Create automatic docker build when pushing to github #132

silkroadnomad opened this issue Feb 25, 2020 · 19 comments
Assignees
Labels
B priority bounty make money enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@silkroadnomad
Copy link
Collaborator

  • create build on docker hub when Github gets updated (pushed)
  • use Doichain dApp version as automatic docker tag version
@silkroadnomad silkroadnomad added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers bounty make money labels Feb 25, 2020
@silkroadnomad silkroadnomad self-assigned this Feb 25, 2020
@silkroadnomad silkroadnomad changed the title Create automatic docker build when pusing to github Create automatic docker build when pushing to github Mar 4, 2020
@jay-dee7
Copy link
Contributor

jay-dee7 commented Mar 9, 2020

@inspiraluna is the bounty open to public? Or is it just for internal references?

@silkroadnomad
Copy link
Collaborator Author

silkroadnomad commented Mar 9, 2020

@jay-dee7 thank you for your interaction. Actually I personally started doing it the other day but it still has issues. If you'd like to help, I'd be more then happy for some support from your side as you seem to be an expert here. We'd offer a bounty of 50 DOI so far. And more if its a bigger problem. I think its just a little thing as always and an easy bounty for people who know whats the issue. So far it triggers a build on docker hub. But when building the image it cannot find certain files: See:

https://github.com/Doichain/dapp/tree/master/contrib/docker/dapp
I added a public bounty on that on https://bounties.doichain.org/ - Feel free to contact me again!

Bildschirmfoto 2020-03-09 um 13 30 16

@jay-dee7
Copy link
Contributor

jay-dee7 commented Mar 9, 2020

Sure @inspiraluna. I'll give it a shot today evening 😁

@jay-dee7
Copy link
Contributor

jay-dee7 commented Mar 9, 2020

@inspiraluna one quick question, do you want to build the image using github actions and then push it to docker hub or dockerhub-github integration from hub.docker.com?

@silkroadnomad
Copy link
Collaborator Author

silkroadnomad commented Mar 9, 2020

Afaik hub.docker.com installs a webhook on github in the end. And as somebody pushs to github it informs hub.docker.com to build a certain Dockerfile. So I guess its the dockerhub-github integration from hub.docker.com which asks the github profile. You could make a fork from our doichain/dapp repository and reference it on your own hub.docker.com. It should build the above mentioned Dockerfile inside here: https://github.com/Doichain/dapp/tree/master/contrib/docker/dapp
If it builds for you, you could post the configuration here.

@jay-dee7
Copy link
Contributor

jay-dee7 commented Mar 9, 2020

i cant see any dockerfile inside this dir: https://github.com/Doichain/dapp/tree/master/contrib/docker/dapp
the readme in there refers to a dockerfile in here: https://github.com/Doichain/docker.git

@silkroadnomad
Copy link
Collaborator Author

can you switch to branch 0.0.9 ?

@jay-dee7
Copy link
Contributor

jay-dee7 commented Mar 9, 2020

yeah sure @inspiraluna. found it

@jay-dee7
Copy link
Contributor

jay-dee7 commented Mar 9, 2020

@inspiraluna am i doing something wrong or are the build times really high? it's been 40+ minutes on docker hub and it's still building

@silkroadnomad
Copy link
Collaborator Author

yes, I think the build time is quite high and also the resulting image is in my opinion far to big. Thinking on another bounty to improve that. What do you think about this?

@jay-dee7
Copy link
Contributor

Another bounty sounds great to me. There's a tool named dive i guess. We can inspect docker layers and try to optimize it

@silkroadnomad
Copy link
Collaborator Author

silkroadnomad commented Mar 10, 2020

I created #139. Let me know if the image builds on docker hub, so we can finalize this bounty or if you encounter the same "file not found" issues as I did. I guess its a context think. But not sure where to look at the moment.

@jay-dee7
Copy link
Contributor

@inspiraluna i was able to build the image using two context paths on an ubuntu machine, one from project root (context path = contrib/docker/dapp) and another by cd'ing into the dir contrib/docker/dapp, however i'm not able to see the docker build logs from docker hub, it stays stuck at fetching the logs screen after failing:
image

@jay-dee7
Copy link
Contributor

can you share what context did you use? in the docker hub build config

@jay-dee7
Copy link
Contributor

this is how my configuration looks like
Screenshot 2020-03-10 at 3 02 36 PM

@jay-dee7
Copy link
Contributor

hey @inspiraluna from my fork, it's building just fine, however the image size magically appears to be 1.7GB which is much much smaller for a first build, can you please pull this image and verify if nothing breaks? also it'll be good if you can give a look at my WIP PR here #140

docker image: docker pull jasdeepsingh/doichain-docker:latest

@jay-dee7
Copy link
Contributor

jay-dee7 commented Mar 10, 2020

@inspiraluna since the build seems to be working fine, can i raise a claim for the bounty? if yes, can i get it in eth?

@silkroadnomad
Copy link
Collaborator Author

silkroadnomad commented Mar 10, 2020

Hey, sure you can claim the bounty. But the payout is only in DOI. Contact me on telegram if you have questions on such details. Also send me your Doichain address in a PM. Alternatively I can send you a paper wallet to your email if you don't have a running node or Doichain wallet yet. All in all please be a bit patient with changing it into other cryptos.

@jay-dee7
Copy link
Contributor

umm the only reason was because coinbase doesnt have doichain on their list yet and i really wanted to avoid multiple wallets, im not looking into converting it into cryptos as well, just wanna get some and let them ripe. i'm PM'ing you right now on telegram.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B priority bounty make money enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants