$caller

[ajmalton]

Anyone remember what $caller is/was for? Something something All Souls day... but it looks obsolete now. Unless I’ve missed something.

[gregordick]

It looks like it's used to distinguish between All Souls' day and the office of the dead said for other reasons. The former ends after None, but the latter is said whenever the user requests it:

divinum-officium/web/cgi-bin/horas/horascommon.pl

Lines 487 to 495 in f35b455

	} elsif (($version !~ /1960|Newcal|Monastic/ || $dayofweek == 6)
	&& $hora =~ /(Vespera|Completorium)/i
	&& $month == 11
	&& $srank =~ /Omnium Fidelium defunctorum/i
	&& !$caller)
	{
	# Office of All Souls' day ends after None.
	$srank[2] = 1;
	$srank = '';

This results in these two behaving differently from one another:

https://divinumofficium.com/cgi-bin/horas/Pofficium.pl?date1=11-2-2021&command=prayVespera&version=Divino%20Afflatu&testmode=regular&lang2=English&votive=&caller=1
https://divinumofficium.com/cgi-bin/horas/Pofficium.pl?date1=11-2-2021&command=prayVespera&version=Divino%20Afflatu&testmode=regular&lang2=English&votive=

And then there's this:

divinum-officium/web/cgi-bin/horas/horascommon.pl

Line 371 in f35b455

if ($caller && $hora =~ /(Matutinum|Laudes)/i) { $sname =~ s/11-02t/11-02/; }

The intention isn't obvious to me, but it feels like a workaround for some interaction between 11-02t (which is the day within the octave of All Saints... or would be if that file existed...) and the explicitly-requested office of the dead.

[ajmalton]

Yes, it looks like that was the intent. However it seems to be broken, and unless I've missed it there is no UI that allows the feature to be used.

[gregordick]

It looks like it could in principle be triggered via the UI, using the links generated using the %...% syntax, if we populated the dirge lines in the transfer tables. But we don't. I think it's fine to purge if this would make life easier.