Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snapshot test to dialog.test.js #962

Open
Darper opened this issue Oct 9, 2018 · 2 comments
Open

Add snapshot test to dialog.test.js #962

Darper opened this issue Oct 9, 2018 · 2 comments
Labels
JS Tests

Comments

@Darper
Copy link
Contributor

Darper commented Oct 9, 2018

The previous snapshot test was returning a false positive so it was deleted. This was caused by something in Portal.js, most likely ReactDOM.unstable_renderSubtreeIntoContainer() which has been replaced by ReactDOM.createPortal(). Please investigate.
@FacuRossi
Copy link

I would like to work in this test.

@Darper
Copy link
Contributor Author

Darper commented Oct 11, 2018

@FacuRossi Thanks! Let us know if you identify a solution. I spent a little time trying to implement ReactDOM.createPortal() but could never actually get any content to show up with the modal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
JS Tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Darper @FacuRossi