-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Make formatting actions toggle instead of only adding #29
Comments
How I'm imagining this could work:
|
@Dibasic That would potentially generate invalid XML / HTML. Consider the following:
Where the selected text is:
We will end up with
|
How I'm imagining this could work:
This ensures valid XML/HTML, but acts a little strange. If you have any amount of characters selected in a bold line, and you perform the bold formatting action, the entire line will stop being bold. |
Tricky. I don't know how this should behave if the user selects something that spans several tags, spans more closing tags than opening tags, etc. |
Overall tricky feature. Perhaps look in to how other WYSIWYG editors accomplish this? |
Is your feature request related to a problem? Please describe.
Currently, every time you do a formatting action (use a hotkey, or press a button), it adds a new tag.
This is not intuitive, because users are used to UX like in MS-Word, where for example pressing Bold on already bold text makes it not bold.
Describe the solution you'd like
Make formatting actions toggle instead of only adding
Describe alternatives you've considered
Or don't.
Additional context
N/A
The text was updated successfully, but these errors were encountered: