Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more test coverage, implement integration testing #22

Open
Diapolo10 opened this issue May 1, 2021 · 4 comments
Open

Add more test coverage, implement integration testing #22

Diapolo10 opened this issue May 1, 2021 · 4 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed test Improvements to automated testing

Comments

@Diapolo10
Copy link
Owner

At present, the critical parts of the library have decent unit test coverage (not that it shows because Coveralls integration is still missing), but more should be added. Furthermore the library could use some integration testing.

@Diapolo10 Diapolo10 added good first issue Good for newcomers test Improvements to automated testing labels May 1, 2021
@Diapolo10 Diapolo10 self-assigned this May 1, 2021
@ben-hill33
Copy link
Contributor

Good afternoon! You mind if I contribute to this?

@Diapolo10
Copy link
Owner Author

Good afternoon! You mind if I contribute to this?

Sure, go right on ahead!

@ben-hill33
Copy link
Contributor

Thanks! So I was a little confused on what needed to be covered so I just looked at the the top of the test file to see what methods were being imported that wasn't used yet, compared the function being tested to what it was checking for from the original file, and just ran a few assertions.
It was my first time make a real contribution to a project, so thank you for the opportunity and I apologize if I wasn't really any help!

@Diapolo10
Copy link
Owner Author

That confusion is entirely my fault, I haven't had time to write proper documentation or detailed issues yet as for the last few months I've been razor-focused on an issue with the CI/CD build system, which I finally managed to fix today (for now).

I'm not fussy about what assertions people add, everything helps as long as it's not just duplicating existing cases.

I'll be sure to read through your pull request and approve it unless there's something really weird going on, and thank you for your time! Feel free to contribute in other ways if you see something that interests you.

@Diapolo10 Diapolo10 added the help wanted Extra attention is needed label Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed test Improvements to automated testing
Projects
None yet
Development

No branches or pull requests

2 participants