-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement 3D connected component analysis #29
Open
dimitrivlachos
wants to merge
37
commits into
main
Choose a base branch
from
3d_connected_components
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or improved organization and encapsulation
…ap indexing in order to provide a framework for three dimensional connections
…nter management and mutex protection for connected components
dimitrivlachos
commented
Feb 7, 2025
FetchContent_Declare( | ||
dx2 | ||
GIT_REPOSITORY https://github.com/dials/dx2 | ||
GIT_TAG main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a review, this is the only thing holding up the PR as I await dials/dx2#2 to be merged so I can tag it explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements 3D connected components analysis into the
Fast FeedbackService
, enabling the processing of rotation datasetswhile maintaining real-time feedback.
Previously, connected components — spots — were processed per
image, treating each frame as independent 2D data. However, in rotation
datasets, spots extend across multiple images, forming 3D reflections
that require all collected frames to fully resolve. At the same time,
real-time feedback still depends on per-frame 2D calculations.
This update enables both:
feedback.
and efficient 3D analysis.
Changes:
ConnectedComponents
into separate files for improvedmodularity, readability and logical grouping.
Signal
andReflection
objects for data encapsulation.data.
max_peak_centroid_separation
andmin_spot_size_3d
dx2
for writing 3D connected components to a reflectiontable.
The dx2 integration relies on the pending
h5_writer
branch:dials/dx2#2