-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Baseline indexer part1 #25
Open
jbeilstenedmands
wants to merge
75
commits into
DiamondLightSource:main
Choose a base branch
from
jbeilstenedmands:baseline_indexer_part1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Baseline indexer part1 #25
jbeilstenedmands
wants to merge
75
commits into
DiamondLightSource:main
from
jbeilstenedmands:baseline_indexer_part1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
ndevenish
reviewed
Jan 22, 2025
Co-authored-by: Nicholas Devenish <ndevenish@gmail.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the first part of a baseline c++ indexer implementation (doing a fft of the strong spots and finding a list of candidate basis vectors).
Requires dx2 to be added as a subdirectory (this branch: dials/dx2#1).
Can be run as e.g:
Refinement and scoring of basis vector combinations will come as a separate PR once this is merged in.
For now, just for single-sweep, single-panel detector to get started.
Max cell and dmin currently required inputs, pending inclusion of annlib-style code.