Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

846 convert i23 to use device factory #987

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Jan 13, 2025

Part of a series of PRs that addresses

This PR migrates i23 to use the device_factory decorator and builds on

Instructions to reviewer on how to test:

  1. dodal connect i23 succeeds

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@rtuck99 rtuck99 requested a review from a team as a code owner January 13, 2025 17:12
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.60%. Comparing base (84e49b5) to head (7368028).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #987      +/-   ##
==========================================
- Coverage   97.60%   97.60%   -0.01%     
==========================================
  Files         154      154              
  Lines        6468     6465       -3     
==========================================
- Hits         6313     6310       -3     
  Misses        155      155              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rtuck99 rtuck99 force-pushed the 846_device_factory_support_for_ophyd_v1 branch 3 times, most recently from 1b12cef to 709df01 Compare January 29, 2025 16:34
@rtuck99 rtuck99 force-pushed the 846_convert_i23_to_use_device_factory branch from 456f40a to 8bbc2c9 Compare January 30, 2025 09:38
@rtuck99 rtuck99 changed the base branch from 846_device_factory_support_for_ophyd_v1 to main January 30, 2025 09:38
@rtuck99 rtuck99 force-pushed the 846_convert_i23_to_use_device_factory branch from 8bbc2c9 to 271277e Compare January 30, 2025 10:12
@rtuck99 rtuck99 force-pushed the 846_convert_i23_to_use_device_factory branch from 271277e to 7368028 Compare January 30, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant