Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get redis host and password from environment #913

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Conversation

DominicOram
Copy link
Contributor

@DominicOram DominicOram commented Nov 21, 2024

Fixes DiamondLightSource/mx-bluesky#149

Note: This also needed the following adding to the values.yaml for BlueAPI:

  - name: VALKEY_PASSWORD
    valueFrom:
     secretKeyRef:
       name: valkey-secret
       key: requirepass

Instructions to reviewer on how to test:

  1. Confirm matches production at /dls_sw/i04/software/bluesky/scratch/dodal

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.67%. Comparing base (2b18524) to head (b280963).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #913   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files         159      159           
  Lines        6589     6590    +1     
=======================================
+ Hits         6436     6437    +1     
  Misses        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DiamondJoseph
Copy link
Contributor

DiamondJoseph commented Nov 21, 2024

Just noting that the envVar needs to go in the extraEnvVars, in case that half of the ticket is picked up by someone else.

I'd also recommend deploying the Secret as a SealedSecret! Example from p47, docs

@DominicOram
Copy link
Contributor Author

This also needed the following adding to the values.yaml for BlueAPI:

This is now in https://gitlab.diamond.ac.uk/controls/containers/beamline/i04-services/-/blob/main/services/i04-blueapi/values.yaml?ref_type=heads

@DominicOram DominicOram requested a review from a team as a code owner January 21, 2025 13:05
@DominicOram DominicOram merged commit dfc171c into main Feb 5, 2025
18 of 19 checks passed
@DominicOram DominicOram deleted the 149_use_k8s_secrets branch February 5, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find better way to store redis password
3 participants