Add Pilatus implementation for i22 beamline module #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callumforrester
requested changes
Apr 9, 2024
There was a problem hiding this comment.
Looks good, just needs some tests, see test suggestions in #421
|
Requires a release of ophyd-async |
DiamondJoseph
force-pushed
the
pilatus
branch
3 times, most recently
from
e97910d to
05e5bcf
Compare
DiamondJoseph
changed the title
callumforrester
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #406
Adds a Pilatus without the Stats plugin as previously enabled for i22. Configuring the Stats plugin will be handled in ophyd-async more generally with bluesky/ophyd-async#213 et al.
Instructions to reviewer on how to test:
Checks for reviewer