Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes/reduces refenece use on i10 IDs #1032

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Relm-Arrowny
Copy link
Contributor

@Relm-Arrowny Relm-Arrowny commented Jan 29, 2025

Fixes #1029 and #1046.

Instructions to reviewer on how to test:

  1. Run test.
  2. Confirm connection.

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@Relm-Arrowny Relm-Arrowny linked an issue Jan 29, 2025 that may be closed by this pull request
8 tasks
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 94.80519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 97.57%. Comparing base (84e49b5) to head (e2a72f3).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/dodal/devices/i10/i10_apple2.py 90.47% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1032      +/-   ##
==========================================
- Coverage   97.60%   97.57%   -0.03%     
==========================================
  Files         154      159       +5     
  Lines        6468     6557      +89     
==========================================
+ Hits         6313     6398      +85     
- Misses        155      159       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Relm-Arrowny Relm-Arrowny linked an issue Feb 7, 2025 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PGM/appl2_undulator timing out eariy Removes/reduces refenece use on i10 IDs
1 participant