Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

230 bimorph optimisation plan #1027

Open
wants to merge 168 commits into
base: main
Choose a base branch
from

Conversation

dan-fernandes
Copy link
Contributor

Adds a bimorph optimisation plan to dodal.

Instructions to reviewer on how to test:

  1. Check all tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@dan-fernandes dan-fernandes requested a review from a team as a code owner January 28, 2025 11:12
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.65%. Comparing base (413aa34) to head (4efba98).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1027      +/-   ##
==========================================
+ Coverage   97.51%   97.65%   +0.14%     
==========================================
  Files         152      160       +8     
  Lines        6346     6619     +273     
==========================================
+ Hits         6188     6464     +276     
+ Misses        158      155       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dan-fernandes
Copy link
Contributor Author

Waiting on: #992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants