Fixes for ophyd-async 0.9.0a2 #1014
Open
+311
−246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
|
|
||
| from dodal.devices.i13_1.merlin_io import MerlinDriverIO, MerlinImageMode | ||
|
|
||
|
|
||
| class MerlinController(DetectorController): | ||
| class MerlinController(ADBaseController): |
There was a problem hiding this comment.
I didn't properly check if this is correct but it looked about right
| @@ -327,7 +327,7 @@ async def test_prepare_sets_up_writer( | |||
| assert (await tetramm.hdf.num_extra_dims.get_value()) == 0 | |||
| assert await tetramm.hdf.lazy_open.get_value() | |||
| assert await tetramm.hdf.swmr_mode.get_value() | |||
| assert (await tetramm.hdf.file_template.get_value()) == "%s/%s.h5" | |||
| assert (await tetramm.hdf.file_template.get_value()) == "%s%s.h5" | |||
There was a problem hiding this comment.
Don't know if this change in syntax could break anything for anyone?
There was a problem hiding this comment.
Looking to try and find where this has even come from
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1014 +/- ##
==========================================
+ Coverage 97.52% 97.54% +0.01%
==========================================
Files 154 154
Lines 6393 6395 +2
==========================================
+ Hits 6235 6238 +3
+ Misses 158 157 -1 ☔ View full report in Codecov by Sentry. |
|
@DiamondJoseph It's pretty much there now but please can you check the linting ins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1017
DeviceCollector renamed to init_device
sim.demo module renamed to sim
Initialisation arguments for HDF detectors change slightly as a result of added support for non-hdf writers
save_pandautility plan updated to use new ophyd-async saveMerlin now inherits from
ADBaseControllerInstructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}