Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sns dual arm robot #1

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Conversation

matt-shinfang
Copy link

@matt-shinfang matt-shinfang commented Dec 6, 2024

  • Add support for sns dual arm robot
  • Update curobo to v0.7.6

Merge with :

Add support for sns dual arm robot
Update curobo to v0.7.6
@matt-shinfang matt-shinfang self-assigned this Dec 6, 2024
@matt-shinfang
Copy link
Author

matt-shinfang commented Dec 6, 2024

cumotion_planner.py get formatted, so it is hard to see what changes...
I will just pinpoint out the place I changed.

},
}
)
world_cfg = WorldConfig()
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to empty WorldConfig, as the world will be get from planning scene.

},
collision_checker_type=CollisionCheckerType.VOXEL,
collision_checker_type=CollisionCheckerType.MESH,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change CollisionCheckerType to mesh

SFhmichael and others added 2 commits February 4, 2025 15:25
Fix issue no urdf file after build

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file had the same information as sns_description provided, can sns_description used here. Does this file need to be changed when description file changed? If yes, I think it's not easy to maintain at all.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this urdf needs to be "pure" urdf. The one with have in sns_description is actually a xacro.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar issue, shall we keep acceleration the same as joint_limits.yaml file in sns_moveit_config?

Copy link
Author

@matt-shinfang matt-shinfang Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, probably should. But we don't have jerk limit available, and I think the ur's acceleration limits are not really publicly available. The numbers we have are copied from shadow.

@SFhmichael SFhmichael merged commit 049901c into main Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants