fix collecting on nested suites not removing the fake test

pytest_robotframework/_common.py

@@ -105,22 +105,21 @@ def visit_suite(self, suite: running.TestSuite):
                 item.stash[running_test_case_key] = test_case
         if self.collect_only:
             suite.tests.clear()  # type:ignore[no-untyped-call]
-            return
-
-        # remove any .robot tests that were filtered out by pytest (and the fake test
-        # from `PythonParser`):
-        for test in suite.tests[:]:
-            if not get_item_from_robot_test(self.session, test):
-                suite.tests.remove(test)
-
-        # add any .py tests that were collected by pytest
-        for item in self.session.items:
-            if isinstance(item, Function):
-                module = cast(ModuleType, item.module)
-                if module.__doc__ and not suite.doc:
-                    suite.doc = module.__doc__
-                if item.path == suite.source:
-                    suite.tests.append(item.stash[running_test_case_key])
+        else:
+            # remove any .robot tests that were filtered out by pytest (and the fake test
+            # from `PythonParser`):
+            for test in suite.tests[:]:
+                if not get_item_from_robot_test(self.session, test):
+                    suite.tests.remove(test)
+
+            # add any .py tests that were collected by pytest
+            for item in self.session.items:
+                if isinstance(item, Function):
+                    module = cast(ModuleType, item.module)
+                    if module.__doc__ and not suite.doc:
+                        suite.doc = module.__doc__
+                    if item.path == suite.source:
+                        suite.tests.append(item.stash[running_test_case_key])
         super().visit_suite(suite)
 
     @override

tests/fixtures/test_python/test_collect_only_nested_suites/asdf/test_bar.py

@@ -0,0 +1,5 @@
+from __future__ import annotations
+
+
+def test_func2():
+    pass

tests/fixtures/test_python/test_collect_only_nested_suites/asdf/test_foo.py

@@ -0,0 +1,5 @@
+from __future__ import annotations
+
+
+def test_func1():
+    pass

tests/fixtures/test_robot/test_collect_only_nested_suites/bar.robot

@@ -0,0 +1,3 @@
+*** Test Cases ***
+Bar
+    Fail

tests/fixtures/test_robot/test_collect_only_nested_suites/foo.robot

@@ -0,0 +1,3 @@
+*** Test Cases ***
+Foo
+    Fail

tests/test_python.py

@@ -123,6 +123,14 @@ def test_doesnt_run_when_collecting(pytester_dir: PytesterDir):
     assert not (pytester_dir.path / "log.html").exists()
 
 
+# TODO: this test doesnt actually test anything
+# https://github.com/DetachHead/pytest-robotframework/issues/61
+def test_collect_only_nested_suites(pytester_dir: PytesterDir):
+    result = run_pytest(pytester_dir, "--collect-only")
+    assert result.parseoutcomes() == {"tests": 2}
+    assert "<Function test_func2>" in (line.strip() for line in result.outlines)
+
+
 def test_correct_items_collected_when_collect_only(pytester_dir: PytesterDir):
     result = run_pytest(pytester_dir, "--collect-only", "test_bar.py")
     assert result.parseoutcomes() == {"test": 1}

tests/test_robot.py

@@ -196,6 +196,14 @@ def test_correct_items_collected_when_collect_only(pytester_dir: PytesterDir):
     assert "<RobotItem Bar>" in (line.strip() for line in result.outlines)
 
 
+# TODO: this test doesnt actually test anything
+# https://github.com/DetachHead/pytest-robotframework/issues/61
+def test_collect_only_nested_suites(pytester_dir: PytesterDir):
+    result = run_pytest(pytester_dir, "--collect-only")
+    assert result.parseoutcomes() == {"tests": 2}
+    assert "<RobotItem Bar>" in (line.strip() for line in result.outlines)
+
+
 def test_doesnt_run_tests_outside_path(pytester_dir: PytesterDir):
     run_and_assert_result(pytester_dir, pytest_args=["foo"], passed=1)
     assert_log_file_exists(pytester_dir)