jupyter notebook support #424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DetachHead
force-pushed
the
jupyter
branch
2 times, most recently
from
01b122d to
ab07a44
Compare
DetachHead
commented
Jun 19, 2024
Comment on lines
402
to
405
| registerJupyterPythonPathFunction: (func) => { | ||
| console.log( | ||
| `registerJupyterPythonPathFunction was called. not sure what it's supposed to do with it so..... ${func}` | ||
| ); |
There was a problem hiding this comment.
should probably try and figure out what this is before merging
|
after looking at how ruff does it, i decided this approach sucks. instead we should add support for typechecking notebooks in the CLI and add support for them in the LSP itself, rather than trying to do it the pylance way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #173
stuff to address before merging:
PYLANCE_EXTENSION_IDto"detachhead.basedpyright". if this is the only change we need to make it would be a pain if we had to fork and publish our own version just for that, maybe there's a way we can hack the official extension at runtime?"basedpyright.importStrategy": "fromEnvironment"). i don't know enough about the development workflow of jupyter notebooks users to know if this is a problem or not. (ie. is type checking notebooks in CI a thing?)