jupyter attempt 3 #1035

DetachHead · 2025-02-02T10:37:34Z

fixes #173

packages/vscode-pyright/src/extension.ts

packages/pyright-internal/src/analyzer/sourceFile.ts

packages/pyright-internal/src/pyright.ts

johnpmayer · 2025-02-02T22:33:18Z

Tested this out, some feedback:

Doesn't appear that the cross-cell stuff (the chained file stuff?) is working
It's very idiomatic to have a bare expression as the last line of a cell, that shouldn't have an "expression value is unused" warning since that expression is going to be displayed in the notebook UI
- This is a nice-to-have

Tested this branch with the following steps (maybe that's my issue)

npm install && npm run build:extension

And then manually installed the .vsix and reloaded the window.

DetachHead · 2025-02-02T22:44:09Z

Doesn't appear that the cross-cell stuff (the chained file stuff?) is working

hmm it seems to work for me. would you be able to provide an example where it doesn't?

johnpmayer · 2025-02-02T22:49:11Z

Yeah it's such a simple one, I'm thinking it must be how I'm installing the built extension (I wouldn't think using bundled/installed lang server would make a difference, but I tried that too, not sure if I did it correctly - User/Remote/Workspace settings always throw me)

{
 "cells": [
  {
   "cell_type": "code",
   "execution_count": 2,
   "metadata": {},
   "outputs": [
    {
     "data": {
      "text/plain": [
       "46"
      ]
     },
     "execution_count": 2,
     "metadata": {},
     "output_type": "execute_result"
    }
   ],
   "source": [
    "import os\n",
    "\n",
    "x = len(os.environ)\n",
    "x"
   ]
  },
  {
   "cell_type": "code",
   "execution_count": 3,
   "metadata": {},
   "outputs": [],
   "source": [
    "foo = 123"
   ]
  },
  {
   "cell_type": "code",
   "execution_count": 4,
   "metadata": {},
   "outputs": [
    {
     "ename": "ModuleNotFoundError",
     "evalue": "No module named 'nothin'",
     "output_type": "error",
     "traceback": [
      "\u001b[0;31m---------------------------------------------------------------------------\u001b[0m",
      "\u001b[0;31mModuleNotFoundError\u001b[0m                       Traceback (most recent call last)",
      "Cell \u001b[0;32mIn[4], line 3\u001b[0m\n\u001b[1;32m      1\u001b[0m foo \u001b[38;5;241m+\u001b[39m \u001b[38;5;241m789\u001b[39m\n\u001b[0;32m----> 3\u001b[0m \u001b[38;5;28;01mimport\u001b[39;00m\u001b[38;5;250m \u001b[39m\u001b[38;5;21;01mnothin\u001b[39;00m\n",
      "\u001b[0;31mModuleNotFoundError\u001b[0m: No module named 'nothin'"
     ]
    }
   ],
   "source": [
    "foo + 789\n",
    "\n",
    "import nothin"
   ]
  }
 ],
 "metadata": {
  "kernelspec": {
   "display_name": ".venv",
   "language": "python",
   "name": "python3"
  },
  "language_info": {
   "codemirror_mode": {
    "name": "ipython",
    "version": 3
   },
   "file_extension": ".py",
   "mimetype": "text/x-python",
   "name": "python",
   "nbconvert_exporter": "python",
   "pygments_lexer": "ipython3",
   "version": "3.12.8"
  }
 },
 "nbformat": 4,
 "nbformat_minor": 2
}

DetachHead · 2025-02-02T22:59:18Z

thanks, i'll have a look later today.

to clarify, you're expecting a type error on that unresolved import of nothin but you don't get one?

johnpmayer · 2025-02-02T23:10:52Z

The error was reportUndefinedVariable on foo in the third cell. The type error on nothin was coming through fine.

However, this all seems to work by following the instructions at docs/development/contributing.md using the provided launch configuration. I think you can ignore my prior report.

johnpmayer · 2025-02-02T23:12:30Z

Rename Symbol across cells doesn't work; either at the definition or usage sites

packages/pyright-internal/src/pyright.ts

…he raw json when outputting to ci

github-actions · 2025-02-08T07:07:57Z

Diff from mypy_primer, showing the effect of this PR on open source code:

bokeh (https://github.com/bokeh/bokeh)
+ /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb - cell 1
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:1:1:8 - warning: Import "bokeh" is not accessed (reportUnusedImport)
+ /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb - cell 2
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:2:1:8 - error: Import "numpy" could not be resolved (reportMissingImports)
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:2:2:1 - warning: Type of "X" is unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:2:2:5 - warning: Type of "linspace" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:2:3:1 - warning: Type of "Y" is unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:2:3:9 - warning: Type of "random" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:2:3:9 - warning: Type of "normal" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:2:3:31 - warning: Type of "shape" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:2:5:1 - warning: Type of "_" is partially unknown
+     Type of "_" is "GlyphRenderer[Unknown]" (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:2:5:3 - warning: Type of "line" is partially unknown
+     Type of "line" is "(...) -> GlyphRenderer[Unknown]" (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:2:6:1 - warning: Type of "_" is partially unknown
+     Type of "_" is "GlyphRenderer[Unknown]" (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:2:6:3 - warning: Type of "line" is partially unknown
+     Type of "line" is "(...) -> GlyphRenderer[Unknown]" (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:2:7:1 - warning: Result of call expression is of type "CommsHandle | None" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
+ /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb - cell 3
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:3:1:1 - warning: Result of call expression is of type "CommsHandle | None" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:3:1:6 - error: Argument of type "Model" cannot be assigned to parameter "obj" of type "UIElement | Sequence[UIElement] | Application | ModifyDoc" in function "show"
+     Type "Model" is not assignable to type "UIElement | Sequence[UIElement] | Application | ModifyDoc"
+       "Model" is not assignable to "UIElement"
+       "Model" is not assignable to "Sequence[UIElement]"
+       "Model" is not assignable to "Application"
+       Type "Model" is not assignable to type "ModifyDoc" (reportArgumentType)
+ /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb - cell 5
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:5:1:8 - warning: "_BokehStructureGraph" is private and used outside of the module in which it is declared (reportPrivateUsage)
+ /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb - cell 6
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:6:1:5 - warning: Type of "x" is partially unknown
+     Type of "x" is "tuple[Unknown, dict[str, Any]]" (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:6:1:10 - warning: Type of "graph" is partially unknown
+     Type of "graph" is "DiGraph[Unknown]" (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:6:1:10 - warning: Type of "nodes" is partially unknown
+     Type of "nodes" is "NodeView[Unknown]" (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:6:2:11 - warning: Argument type is partially unknown
+     Argument corresponds to parameter "values" in function "print"
+     Argument type is "tuple[Unknown, dict[str, Any]]" (reportUnknownArgumentType)
+ /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb - cell 7
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:7:1:1 - warning: Type of "property_df" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:7:2:1 - warning: Type of "property_df" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:7:2:24 - warning: Type of "property_df" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:7:2:24 - warning: Type of "str" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:7:2:24 - warning: Type of "replace" is unknown (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb - cell 8
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:8:1:1 - error: "pd" is not defined (reportUndefinedVariable)
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:8:1:1 - warning: Type of "set_option" is unknown (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb - cell 9
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:9:1:1 - warning: Type of "property_df" is unknown (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb - cell 10
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:10:1:1 - warning: Result of call expression is of type "CommsHandle | None" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
+   /tmp/mypy_primer/projects/bokeh/examples/models/structure/ModelStructureExample.ipynb:10:1:6 - error: Argument of type "Model" cannot be assigned to parameter "obj" of type "UIElement | Sequence[UIElement] | Application | ModifyDoc" in function "show"
+     Type "Model" is not assignable to type "UIElement | Sequence[UIElement] | Application | ModifyDoc"
+       "Model" is not assignable to "UIElement"
+       "Model" is not assignable to "Sequence[UIElement]"
+       "Model" is not assignable to "Application"
+       Type "Model" is not assignable to type "ModifyDoc" (reportArgumentType)
+ /tmp/mypy_primer/projects/bokeh/examples/output/jupyter/push_notebook/Basic Usage.ipynb - cell 3
+   /tmp/mypy_primer/projects/bokeh/examples/output/jupyter/push_notebook/Basic Usage.ipynb:3:1:15 - error: Argument of type "int" cannot be assigned to parameter "tools" of type "str | Sequence[str | Tool]" in function "__init__"
+     Type "int" is not assignable to type "str | Sequence[str | Tool]"
+       "int" is not assignable to "str"
+       "int" is not assignable to "Sequence[str | Tool]" (reportArgumentType)
+   /tmp/mypy_primer/projects/bokeh/examples/output/jupyter/push_notebook/Basic Usage.ipynb:3:1:15 - error: Argument of type "int" cannot be assigned to parameter "x_axis_location" of type "VerticalLocationType | None" in function "__init__"
+     Type "int" is not assignable to type "VerticalLocationType | None"
+       "int" is not assignable to "None"
+       "int" is not assignable to "Literal['above']"
+       "int" is not assignable to "Literal['below']" (reportArgumentType)
+   /tmp/mypy_primer/projects/bokeh/examples/output/jupyter/push_notebook/Basic Usage.ipynb:3:1:15 - error: Argument of type "int" cannot be assigned to parameter "y_axis_location" of type "HorizontalLocationType | None" in function "__init__"
+     Type "int" is not assignable to type "HorizontalLocationType | None"
+       "int" is not assignable to "None"
+       "int" is not assignable to "Literal['left']"
+       "int" is not assignable to "Literal['right']" (reportArgumentType)
+   /tmp/mypy_primer/projects/bokeh/examples/output/jupyter/push_notebook/Basic Usage.ipynb:3:1:15 - error: Argument of type "int" cannot be assigned to parameter "x_axis_label" of type "TextLike | None" in function "__init__"
+     Type "int" is not assignable to type "TextLike | None"
+       "int" is not assignable to "str"
+       "int" is not assignable to "BaseText"
+       "int" is not assignable to "None" (reportArgumentType)
+   /tmp/mypy_primer/projects/bokeh/examples/output/jupyter/push_notebook/Basic Usage.ipynb:3:1:15 - error: Argument of type "int" cannot be assigned to parameter "y_axis_label" of type "TextLike | None" in function "__init__"
+     Type "int" is not assignable to type "TextLike | None"
+       "int" is not assignable to "str"
+       "int" is not assignable to "BaseText"
+       "int" is not assignable to "None" (reportArgumentType)

... (truncated 1289 lines) ...

ignite (https://github.com/pytorch/ignite)
+ /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb - cell 2
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:2:7:5 - warning: Type of "VERSION" is unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:2:7:15 - error: Expected expression
+ /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb - cell 3
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:3:8 - error: Import "torch" could not be resolved (reportMissingImports)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:4:8 - error: Import "torch.nn" could not be resolved (reportMissingImports)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:5:8 - error: Import "torch.optim" could not be resolved (reportMissingImports)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:6:6 - error: Import "torch.optim.lr_scheduler" could not be resolved (reportMissingImports)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:6:38 - warning: Type of "StepLR" is unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:7:6 - error: Import "torchvision" could not be resolved (reportMissingImports)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:7:25 - warning: Type of "datasets" is unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:7:35 - warning: Type of "models" is unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:8:6 - error: Import "torchvision.transforms" could not be resolved (reportMissingImports)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:8:36 - warning: Type of "Compose" is unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:8:45 - warning: Type of "Normalize" is unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:8:56 - warning: Type of "Pad" is unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:8:61 - warning: Type of "RandomCrop" is unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:8:73 - warning: Type of "RandomHorizontalFlip" is unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:8:95 - warning: Type of "ToTensor" is unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:13:43 - warning: Type of "create_supervised_evaluator" is partially unknown
+     Type of "create_supervised_evaluator" is "(model: Unknown, metrics: Dict[str, Metric] | None = None, device: str | Unknown | None = None, non_blocking: bool = False, prepare_batch: (...) -> Unknown = _prepare_batch, model_transform: (Any) -> Any = lambda output: output, output_transform: (Any, Any, Any) -> Any = lambda x, y, y_pred: (y_pred, y), amp_mode: str | None = None, model_fn: (Unknown, Any) -> Any = lambda model, x: model(x)) -> Engine" (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:17:1 - warning: Type of "train_transform" is unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:27:1 - warning: Type of "test_transform" is unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:30:5 - warning: Return type, "tuple[Unknown, Unknown]", is partially unknown (reportUnknownParameterType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:30:29 - warning: Type of parameter "path" is unknown (reportUnknownParameterType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:30:29 - warning: Type annotation is missing for parameter "path" (reportMissingParameterType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:36:5 - warning: Type of "train_ds" is unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:36:16 - warning: Type of "CIFAR10" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:37:5 - warning: Type of "test_ds" is unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:37:15 - warning: Type of "CIFAR10" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:43:12 - warning: Return type, "tuple[Unknown, Unknown]", is partially unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:46:5 - warning: Return type is unknown (reportUnknownParameterType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:46:15 - warning: Type of parameter "name" is unknown (reportUnknownParameterType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:46:15 - warning: Type annotation is missing for parameter "name" (reportMissingParameterType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:47:16 - warning: Type of "__dict__" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:48:9 - warning: Type of "fn" is unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:48:14 - warning: Type of "__dict__" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:52:12 - warning: Return type is unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:55:5 - warning: Return type, "tuple[Unknown | _MpDeviceLoader, Unknown | _MpDeviceLoader]", is partially unknown (reportUnknownParameterType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:55:18 - warning: Type of parameter "config" is unknown (reportUnknownParameterType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:55:18 - warning: Type annotation is missing for parameter "config" (reportMissingParameterType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:57:5 - warning: Type of "train_dataset" is unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:57:20 - warning: Type of "test_dataset" is unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:57:59 - warning: Type of "get" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:57:59 - warning: Argument type is unknown
+     Argument corresponds to parameter "path" in function "get_train_test_datasets" (reportUnknownArgumentType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:60:5 - warning: Type of "train_loader" is partially unknown
+     Type of "train_loader" is "Unknown | _MpDeviceLoader" (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:60:20 - warning: Type of "auto_dataloader" is partially unknown
+     Type of "auto_dataloader" is "(dataset: Unknown, **kwargs: Any) -> (Unknown | _MpDeviceLoader)" (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:61:9 - warning: Argument type is unknown
+     Argument corresponds to parameter "dataset" in function "auto_dataloader" (reportUnknownArgumentType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:62:20 - warning: Type of "get" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:63:21 - warning: Type of "get" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:67:41 - warning: Argument type is partially unknown
+     Argument corresponds to parameter "obj" in function "len"
+     Argument type is "Unknown | _MpDeviceLoader" (reportUnknownArgumentType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:69:5 - warning: Type of "test_loader" is partially unknown
+     Type of "test_loader" is "Unknown | _MpDeviceLoader" (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:69:19 - warning: Type of "auto_dataloader" is partially unknown
+     Type of "auto_dataloader" is "(dataset: Unknown, **kwargs: Any) -> (Unknown | _MpDeviceLoader)" (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:70:9 - warning: Argument type is unknown
+     Argument corresponds to parameter "dataset" in function "auto_dataloader" (reportUnknownArgumentType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:71:24 - warning: Type of "get" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:72:21 - warning: Type of "get" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:75:12 - warning: Return type, "tuple[Unknown | _MpDeviceLoader, Unknown | _MpDeviceLoader]", is partially unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:78:5 - warning: Return type, "tuple[Unknown, Unknown, Unknown, Unknown]", is partially unknown (reportUnknownParameterType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:78:16 - warning: Type of parameter "config" is unknown (reportUnknownParameterType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:78:16 - warning: Type annotation is missing for parameter "config" (reportMissingParameterType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:79:5 - warning: Type of "model" is unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/ignite/assets/tldr/teaser.ipynb:3:79:23 - warning: Argument type is unknown
+     Argument corresponds to parameter "name" in function "get_model" (reportUnknownArgumentType)

... (truncated 4481 lines) ...

xarray (https://github.com/pydata/xarray)
+ /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb - cell 1
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:1:2:8 - error: Import "matplotlib.pyplot" could not be resolved (reportMissingImports)
+ /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb - cell 2
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:2:1:6 - warning: Type of "load_dataset" is partially unknown
+     Type of "load_dataset" is "(...) -> Dataset" (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb - cell 3
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:3:2:1 - warning: Type of "t2m" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:3:2:1 - warning: Type of "plot" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:3:2:21 - warning: Type of "cm" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:3:2:21 - warning: Type of "coolwarm" is unknown (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb - cell 4
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:4:1:8 - error: Import "cartopy.crs" could not be resolved (reportMissingImports)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:4:2:8 - error: Import "cartopy" could not be resolved (reportMissingImports)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:4:2:8 - warning: Import "cartopy" is not accessed (reportUnusedImport)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:4:4:1 - warning: Type of "fig" is unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:4:4:7 - warning: Type of "figure" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:4:5:1 - warning: Type of "ax" is unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:4:5:6 - warning: Type of "axes" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:4:5:26 - warning: Type of "Robinson" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:4:6:1 - warning: Type of "coastlines" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:4:7:1 - warning: Type of "plot" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:4:7:8 - warning: Type of "t2m" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:4:7:8 - warning: Type of "plot" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:4:8:10 - warning: Type of "cm" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:4:8:10 - warning: Type of "coolwarm" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:4:8:37 - warning: Type of "PlateCarree" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:4:10:1 - warning: Type of "title" is unknown (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb - cell 5
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:5:1:1 - warning: Type of "t2m" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:5:1:1 - warning: Type of "sel" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:5:1:1 - warning: Type of "plot" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ERA5-GRIB-example.ipynb:5:2:1 - warning: Type of "title" is unknown (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb - cell 1
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:1:1:8 - error: Import "numpy" could not be resolved (reportMissingImports)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:1:1:17 - warning: Import "np" is not accessed (reportUnusedImport)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:1:2:8 - error: Import "cartopy.crs" could not be resolved (reportMissingImports)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:1:3:8 - error: Import "cartopy.feature" could not be resolved (reportMissingImports)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:1:4:8 - error: Import "matplotlib.pyplot" could not be resolved (reportMissingImports)
+ /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb - cell 2
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:2:2:6 - warning: Type of "open_dataset" is partially unknown
+     Type of "open_dataset" is "(name: str, cache: bool = True, cache_dir: str | PathLike[Unknown] | None = None, *, engine: type[BackendEntrypoint] | str | None = None, **kws: Unknown) -> Dataset" (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb - cell 3
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:1:4 - warning: Type of "Vtransform" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:2:5 - warning: Type of "Zo_rho" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:2:14 - warning: Type of "hc" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:2:23 - warning: Type of "s_rho" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:2:34 - warning: Type of "Cs_r" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:2:45 - warning: Type of "Cs_r" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:2:55 - warning: Type of "h" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:3:5 - warning: Type of "z_rho" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:3:22 - warning: Type of "zeta" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:3:46 - warning: Type of "h" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:4:6 - warning: Type of "Vtransform" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:5:5 - warning: Type of "Zo_rho" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:5:15 - warning: Type of "hc" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:5:23 - warning: Type of "s_rho" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:5:34 - warning: Type of "Cs_r" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:5:44 - warning: Type of "h" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:5:53 - warning: Type of "hc" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:5:61 - warning: Type of "h" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:6:5 - warning: Type of "z_rho" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:6:13 - warning: Type of "zeta" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:6:24 - warning: Type of "zeta" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:6:34 - warning: Type of "h" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:8:22 - warning: Type of "transpose" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:8:22 - error: "z_rho" is possibly unbound (reportPossiblyUnboundVariable)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:3:9:1 - warning: Type of "salt" is Any (reportAny)
+ /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb - cell 4
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:4:1:1 - warning: Type of "salt" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:4:1:1 - warning: Type of "isel" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:4:1:1 - warning: Type of "plot" is Any (reportAny)
+ /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb - cell 5
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:5:1:1 - warning: Type of "section" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:5:1:11 - warning: Type of "salt" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:5:1:11 - warning: Type of "isel" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:5:2:1 - warning: Type of "plot" is Any (reportAny)
+   /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb:5:3:1 - warning: Type of "ylim" is unknown (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/xarray/doc/examples/ROMS_ocean_model.ipynb - cell 6

... (truncated 629 lines) ...

materialize (https://github.com/MaterializeInc/materialize)
+ /tmp/mypy_primer/projects/materialize/test/scalability/scalability.ipynb - cell 1

... (truncated 109 lines) ...```

DetachHead mentioned this pull request Feb 2, 2025

jupyter attempt 2 #442

Closed

DetachHead force-pushed the jupyter3 branch from 1bdf10e to efa0704 Compare February 2, 2025 10:45

DetachHead mentioned this pull request Feb 2, 2025

Support for Jupyter Notebook #173

Closed

This comment has been minimized.

Sign in to view

jupyter notebook support - language server

b7660d4

DetachHead force-pushed the jupyter3 branch from efa0704 to 6e07d45 Compare February 2, 2025 15:53

DetachHead commented Feb 2, 2025

View reviewed changes

packages/pyright-internal/src/analyzer/sourceFile.ts Show resolved Hide resolved

DetachHead commented Feb 2, 2025

View reviewed changes

packages/pyright-internal/src/pyright.ts Show resolved Hide resolved

This comment has been minimized.

Sign in to view

DetachHead force-pushed the jupyter3 branch 2 times, most recently from 2067d83 to eb683f6 Compare February 3, 2025 09:03

This comment has been minimized.

Sign in to view

jupyter notebook support - cli

297398b

DetachHead force-pushed the jupyter3 branch from eb683f6 to 4fe6b01 Compare February 3, 2025 11:16

DetachHead mentioned this pull request Feb 3, 2025

support baseline with jupyter notebooks #1039

Closed

unit tests for jupyter in the cli

9f9f068

This comment has been minimized.

Sign in to view

DetachHead force-pushed the jupyter3 branch from 4fe6b01 to 779c72e Compare February 3, 2025 12:12

This comment has been minimized.

Sign in to view

DetachHead requested a review from johnpmayer February 3, 2025 15:20

This comment has been minimized.

Sign in to view

DetachHead commented Feb 4, 2025

View reviewed changes

packages/pyright-internal/src/pyright.ts Outdated Show resolved Hide resolved

prevent errors in notebooks from being reported on invalid lines in t…

a1d827b

…he raw json when outputting to ci

DetachHead added 4 commits February 4, 2025 19:45

fix first cell not being treated as a cell in the language server

a53a85e

fix renaming symbols across notebook cells

4de3559

dunno if this affects anything

4e15f8f

document jupyter notebook support

2dd7f54

DetachHead force-pushed the jupyter3 branch from 7048b21 to 0f647a7 Compare February 4, 2025 09:45

This comment has been minimized.

Sign in to view

support baselining errors in jupyter notebooks

e97d54a

DetachHead force-pushed the jupyter3 branch from 0f647a7 to e97d54a Compare February 4, 2025 13:55

This comment has been minimized.

Sign in to view

DetachHead force-pushed the jupyter3 branch from 2b13e8d to 178dcfe Compare February 8, 2025 03:48

This comment has been minimized.

Sign in to view

DetachHead force-pushed the jupyter3 branch from 178dcfe to 0781672 Compare February 8, 2025 06:08

rework lsp notebook support to support baseline

201a9d5

DetachHead force-pushed the jupyter3 branch from 0781672 to 201a9d5 Compare February 8, 2025 06:21

DetachHead merged commit d8582a2 into main Feb 8, 2025
20 checks passed

DetachHead deleted the jupyter3 branch February 8, 2025 07:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

jupyter attempt 3 #1035

jupyter attempt 3 #1035

DetachHead commented Feb 2, 2025

This comment has been minimized.

This comment has been minimized.

johnpmayer commented Feb 2, 2025 •

edited

Loading

DetachHead commented Feb 2, 2025 •

edited

Loading

johnpmayer commented Feb 2, 2025

DetachHead commented Feb 2, 2025

johnpmayer commented Feb 2, 2025

johnpmayer commented Feb 2, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Feb 8, 2025

jupyter attempt 3 #1035

jupyter attempt 3 #1035

Conversation

DetachHead commented Feb 2, 2025

This comment has been minimized.

This comment has been minimized.

johnpmayer commented Feb 2, 2025 • edited Loading

DetachHead commented Feb 2, 2025 • edited Loading

johnpmayer commented Feb 2, 2025

DetachHead commented Feb 2, 2025

johnpmayer commented Feb 2, 2025

johnpmayer commented Feb 2, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Feb 8, 2025

johnpmayer commented Feb 2, 2025 •

edited

Loading

DetachHead commented Feb 2, 2025 •

edited

Loading