Fixed a bug that results in a false positive error when a method defi…

…ned within a named tuple is overridden by a subclass. This addresses #7256. (#7259)
DetachHead · Feb 14, 2024 · 4b206e3 · 4b206e3
1 parent 2ff6efb
commit 4b206e3
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 9 deletions.
diff --git a/packages/pyright-internal/src/analyzer/checker.ts b/packages/pyright-internal/src/analyzer/checker.ts
@@ -4783,14 +4783,17 @@ export class Checker extends ParseTreeWalker {
                     // If the parent class is a named tuple, all instance variables
                     // (other than dundered ones) are implicitly final.
                     const decl = localSymbol.getDeclarations()[0];
-                    this._evaluator.addDiagnostic(
-                        DiagnosticRule.reportIncompatibleVariableOverride,
-                        LocMessage.namedTupleEntryRedeclared().format({
-                            name,
-                            className: parentSymbol.classType.details.name,
-                        }),
-                        decl.node
-                    );
+
+                    if (decl.type === DeclarationType.Variable) {
+                        this._evaluator.addDiagnostic(
+                            DiagnosticRule.reportIncompatibleVariableOverride,
+                            LocMessage.namedTupleEntryRedeclared().format({
+                                name,
+                                className: parentSymbol.classType.details.name,
+                            }),
+                            decl.node
+                        );
+                    }
                 }
             }
         });

diff --git a/packages/pyright-internal/src/analyzer/sourceFileInfo.ts b/packages/pyright-internal/src/analyzer/sourceFileInfo.ts
@@ -119,7 +119,7 @@ export class SourceFileInfo {
             this._writableData = this._preEditData;
             this._preEditData = undefined;
 
-            // Some states have changed. Force some of info to be re-calcuated.
+            // Some states have changed. Force some of info to be re-calculated.
             this.sourceFile.dropParseAndBindInfo();
         }
 

diff --git a/packages/pyright-internal/src/tests/samples/namedTuple10.py b/packages/pyright-internal/src/tests/samples/namedTuple10.py
@@ -8,9 +8,15 @@ class Point(NamedTuple):
     x: int
     y: int
 
+    def f(self):
+        pass
+
 
 class BadPointWithName(Point):
     name: str
 
     # This should generate an error.
     x: int
+
+    def f(self):
+        pass