fix pyright errors in python code

DetachHead · Jan 15, 2024 · 1d8a183 · 1d8a183
1 parent 7a2903a
commit 1d8a183
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/basedpyright/run_node.py b/basedpyright/run_node.py
@@ -7,4 +7,4 @@
 
 
 def run(script_name: str):
-    node.run([Path(__file__).parent / f"{script_name}.js", *sys.argv[1:]])
+    _ = node.run([Path(__file__).parent / f"{script_name}.js", *sys.argv[1:]])
diff --git a/pdm_build.py b/pdm_build.py
@@ -3,12 +3,20 @@
 from json import loads
 from pathlib import Path
 from shutil import copyfile, copytree
+from typing import TYPE_CHECKING
 
-from nodejs import npm
+# https://github.com/samwillis/nodejs-pypi/pull/23
+if TYPE_CHECKING:
+    # https://github.com/astral-sh/ruff/issues/9528
+    from subprocess import run as run_  # noqa: S404
+
+    run = run_
+else:
+    from nodejs.npm import run
 
 if not Path("node_modules").exists():
-    _ = npm.run(["ci"], check=True)
-_ = npm.run(["run", "build:cli:dev"], check=True)
+    _ = run(["ci"], check=True)
+_ = run(["run", "build:cli:dev"], check=True)
 
 npm_package_dir = Path("packages/pyright")
 pypi_package_dir = Path("basedpyright")
Original file line number	Diff line number	Diff line change
Expand Up		@@ -7,4 +7,4 @@


		def run(script_name: str):
		node.run([Path(__file__).parent / f"{script_name}.js", *sys.argv[1:]])
		_ = node.run([Path(__file__).parent / f"{script_name}.js", *sys.argv[1:]])