Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove buildx from native image build job #1664

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Remove buildx from native image build job #1664

merged 1 commit into from
Feb 17, 2025

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Feb 13, 2025

Description

Removes buildx from native image build job.

Buildx is not available on the arm64 platform, and also no longer necessary because we don't do cross-compilation anymore.

Addressed Issue

N/A

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Buildx is not available on the arm64 platform, and also no longer necessary because we don't do cross-compilation anymore.

Signed-off-by: Niklas <nscuro@protonmail.com>
@nscuro nscuro added defect Something isn't working ci labels Feb 13, 2025
@nscuro nscuro added this to the 0.6.0 milestone Feb 13, 2025
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+18.22% (target: -1.00%) (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f3912ba) 201 132 65.67%
Head commit (de8c2a7) 6996 (+6795) 5869 (+5737) 83.89% (+18.22%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1664) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit 8326253 into main Feb 17, 2025
13 checks passed
@nscuro nscuro deleted the nscuro-patch-1 branch February 17, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant