176 fix json report download #177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to array before writing
michelleblom
approved these changes
Aug 9, 2024
|
|
||
| // write json by hand to preserve streaming writes in case of big data | ||
| try { | ||
| os.write("[".getBytes(StandardCharsets.UTF_8)); |
There was a problem hiding this comment.
Can resultsArr be final, and the for loop changes to iterate over final Object ...? Could push the results.toArray() into the for loop parens I suppose, but it doesn't make a lot of difference.
|
I'm closing this PR without merge - I cherrypicked the actually-important commit into a different PR: #178 to deal with the old unsigned commits, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.