162 reaudit step not working #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… already been reaudited.
…it a cvr that wasn't previously audited.
…udit a cvr that wasn't previously audited.
michelleblom
approved these changes
Aug 9, 2024
| Persistence.getByID(cvr.id(), CVRAuditInfo.class); | ||
| final CastVoteRecord oldAcvr = cai.acvr(); | ||
| if (null == oldAcvr) { | ||
|
|
There was a problem hiding this comment.
We could perhaps use DD or Democracy Developers rather than individual initials?
| * 6. a vote that doesn't properly correspond to the IDs it should have, and | ||
| * 7. an unparseable vote (typos in json data). | ||
| * 6. a vote that doesn't properly correspond to the IDs it should have, | ||
| * 7. an unparseable vote (typos in json data), |
|
|
||
| // Seventh test: upload a vote that has typos preventing json deserialization. This should | ||
| // cause an error. | ||
| testErrorResponse(240515L, IRVJsonDeserializationFail, malformedACVRMsg); | ||
| testErrorResponseAndNoMatchingCvr(240515L, IRVJsonDeserializationFail, malformedACVRMsg); | ||
|
|
| testSuccessResponse(240509L, "1-1-1", validIRVReauditAsJson, List.of("Alice","Chuan"), 3); | ||
| // Test that the previous upload, with a vote for Bob and Chuan (validIRVAsJson) is now tagged as REAUDITED. | ||
| testPreviousAreReaudited(240509L, "1-1-1", List.of("Bob","Chuan"), 1, 1); | ||
|
|
There was a problem hiding this comment.
"same ballot being reaudited" ?
| assertTrue(acvrs.stream().allMatch(cvr -> cvr.imprintedID().equals(expectedImprintedId))); | ||
|
|
||
| // Find the maximum revision; check that it matches the expected maximum revision (this should match the number of | ||
| // reaudits). |
There was a problem hiding this comment.
Minor point: can maxRevision or maxRevisionAcvrs be final?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two bugs in the reaudit phase, both of which caused nullpointer exceptions. It also adds some tests for proper functioning of various IRV reaudit attempts.