Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generic reports with IRV winners; integrate IRV into existing reports #137

Closed
vteague opened this issue Jun 26, 2024 · 8 comments · Fixed by #185
Closed

Update generic reports with IRV winners; integrate IRV into existing reports #137

vteague opened this issue Jun 26, 2024 · 8 comments · Fixed by #185
Assignees
Milestone

Comments

@vteague
Copy link
Member

vteague commented Jun 26, 2024

Depends on #136

ReportRows::genSumResultsReport currently calls ContestResult::getWinners to get the winner - update it to use the IRV winners table (or errors) instead.

@vteague vteague added this to the IRV Reports milestone Jun 26, 2024
@vteague vteague moved this to Design/specify in CO IRV RLA Jun 26, 2024
@vteague vteague self-assigned this Aug 7, 2024
@vteague
Copy link
Member Author

vteague commented Aug 7, 2024

genSumResultsReport() was already updated in #136.

@vteague
Copy link
Member Author

vteague commented Aug 7, 2024

First pass at what may need updating, from resources/SQL:

  • auditboard.sql - no update.
  • batch_count_comparison.sql - no update.
  • contest.sql - no update.
  • contest_comparison.sql - update with invalid IRV ballots pre-interpretation.
  • contest_selection.sql - no change.
  • contests_by_county.sql - no change.
  • ranked_ballot_interpretation.sql - new, specific to IRV.
  • seed.sql - no change.
  • tabulate.sql - restrict to plurality only.
  • ** add a new one that "tabulates" IRV by just pulling the GenerateAssertionSummaries.
  • tabulate_county.sql - restrict to plurality only.
  • upload_status.sql - no change.
  • ActivityReport.xls - no change.

@vteague
Copy link
Member Author

vteague commented Aug 8, 2024

Also update state-general... .xlsx to have proper IRV data when IRV contests are audited.

@vteague vteague changed the title Update generic reports with IRV winners Update generic reports with IRV winners; integrate IRV into existing reports Aug 8, 2024
@vteague
Copy link
Member Author

vteague commented Aug 8, 2024

  • Correct summary table of Results report - get margin and diluted margin from IRVComparisonAudit, not ContestResult.
  • Check with CDOS what they'd like the Summary of state-general...xlsx to look like for IRV.

@vteague
Copy link
Member Author

vteague commented Aug 10, 2024

  • Check discrepancy in ActivityReport.xls.
  • min margin and diluted margin in ResultsReport, in county-specific sheets as well as in summary.
  • discrepancies in ResultsReport, in both the summary and the individual ones.

@vteague
Copy link
Member Author

vteague commented Aug 10, 2024

  • Min margin in ResultsReport is certainly wrong. Boulder Mayoral should be 1228.

@vteague
Copy link
Member Author

vteague commented Aug 10, 2024

  • Maybe we should add "risk limit met Y/N" to the assertions csv.

@vteague
Copy link
Member Author

vteague commented Aug 11, 2024

Decisions:

  • Discrepancies seem OK after a cursory check. Need more complete testing.
  • In the ResultsReport and state reports, decided to just omit everything but the contest name and the list of choices. All the necessary data (who won, the margins, etc), are in the IRV-specific reports anyway.

@vteague vteague linked a pull request Aug 16, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in CO IRV RLA Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant