Install julia via pixi #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And install julia via juliaup
And that windows long paths need to be enabled
deltamarnix
commented
Dec 8, 2023
deltamarnix
commented
Dec 8, 2023
Comment on lines
+173
to
+174
| [system-requirements] | ||
| linux = "3.10.0" |
There was a problem hiding this comment.
This was needed for the linux build. We could leave it out of this PR, I don't know if there is anyone with a linux system that wants to test if it is working for ubuntu.
Hofer-Julian
reviewed
Dec 8, 2023
|
Julia tests are failing, since the steps are not compliant to what we do in pixi. We need to use the correct environment and no need to install julia here. steps:
- uses: actions/checkout@v4
- uses: prefix-dev/setup-pixi@v0.4.1
with:
pixi-version: "latest"
- name: Prepare pixi
run: pixi run install-without-pre-commit
- name: Prepare model input
run: |
pixi run generate-testmodels
- uses: julia-actions/setup-julia@v1
with:
version: ${{ matrix.julia_version }}
arch: ${{ matrix.arch }}
- uses: julia-actions/cache@v1
with:
cache-compiled: "true"
cache-registries: "true"
- uses: julia-actions/julia-buildpkg@v1
with:
project: core
- uses: julia-actions/julia-runtest@v1
with:
project: core
- uses: julia-actions/julia-processcoverage@v1
with:
directories: core/src
- uses: codecov/codecov-action@v3
with:
files: lcov.info |
|
@visr My branch is still failing, even after a simple retry. This is the error |
|
Also, github action now builds julia twice, which is unnecessary, we should fix that in a new PR. I will make a ticket for it when this branch is merged. |
visr
reviewed
Dec 8, 2023
Co-authored-by: Martijn Visser <mgvisser@gmail.com>
deltamarnix
force-pushed
the
feat/linux-build
branch
from
afdfd2a to
16c854b
Compare
Instantiate will already be called during the call of any task in pixi
| @@ -76,6 +76,10 @@ test-ribasim-core = { cmd = "julia --project=core --eval 'using Pkg; Pkg.test()' | |||
| "instantiate-julia", | |||
| "generate-testmodels", | |||
| ] } | |||
| test-ribasim-core-cov = { cmd = "julia --project=core --eval 'using Pkg; Pkg.test(coverage=true, julia_args=[\"--check-bounds=yes\"])'", depends_on = [ | |||
There was a problem hiding this comment.
I am not sure if the check-bounds flag is needed. I couldn't find a single @inbounds in our code.
What do you say @visr?
There was a problem hiding this comment.
I would be fine with disabling it. Our dependencies do use that I assume, but probably they are testing with check-bounds.
There was a problem hiding this comment.
It's not really in the way, is it?
There was a problem hiding this comment.
My idea was to reduce the number of options we pass. I am fine with keeping it if you prefer that
But only use it when creating binaries
Hofer-Julian
approved these changes
Dec 13, 2023
visr
added a commit
that referenced
this pull request
Jul 8, 2024
In #878 we started installing julia via pixi. We kept the packages shared under `~/.julia` to avoid unnecessary duplication. We did put the julia installation under `utils/juliaup` by setting JULIAUP_DEPOT_PATH. This way we could set a default channel for our juliaup. However if we can manage to set the default channel for our repository having the julia installations in the normal place is preferred, because it won't have to download julia versions that are already installed. Looking at [`juliaup override`](https://github.com/JuliaLang/juliaup?tab=readme-ov-file#overrides) we can achieve this with `juliaup override set 1.10.4`. This also has the advantage that you get the desired channel with both `pixi run julia` and `julia`. That's nice because my global default channel is 1.11. ``` ❯ juliaup override status Path Channel --------------- Ribasim on home-depot [$!?] via ஃ v1.10.4 via 🐍 ❯ pixi run install-julia ✨ Pixi task (install-julia in dev): juliaup add 1.10.4 && juliaup override set 1.10.4 '1.10.4' is already installed. Ribasim on home-depot [$!?] via ஃ v1.10.4 via 🐍 took 3s ❯ juliaup override status Path Channel ---------------------------------- D:\repo\ribasim\Ribasim 1.10.4 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One step less in installing your development environment. Juliaup is now installed via pixi and the julia executable itself with the supported version is installed in
<project>/juliaup. The packages that we use within julia are still shared, as they are not precompiled in~/.julia.This enables us to build our packages without using the pre-installed versions of julia on our Teamcity build agents.
Julia is only installed once via pixi on Github Actions, it then performs the tests over
pixi run test-ribasim-core-cov.Part of #93