Fix link_type migration #2025
Merged
Fix link_type migration #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I'm surprised none of the existing migration tests picked up this pattern? Would be good to add that. |
|
The migration didn't fail, it only failed validation when writing it out. I added decbc87 which would've failed and now shouldn't. |
evetion
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't write migrated models to disk because the validation failed because the Link table had
link_typetwice. One version was filled in with defaults on load since it was missing, and the second one came from the migration code.This removes link_type before renaming, just like was done for min_crest_level, and uses a new method to capture this pattern and test it.