Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Edge to Link #2023

Merged
merged 6 commits into from
Jan 30, 2025
Merged

Rename Edge to Link #2023

merged 6 commits into from
Jan 30, 2025

Conversation

evetion
Copy link
Member

@evetion evetion commented Jan 29, 2025

everywhere

This is automatic rename, and then slowly staging the changes. Main exceptions found so far:

  • UGrid uses edge_dimension and similar names
  • Networkx has a Graph edges attribute and methods
  • Graphs.jl has an edges method and keywords

@visr The only breaking change are that output arrow tables now have link_id instead of edge_id. I don't think there's a way around that.

@evetion evetion requested a review from SouthEndMusic January 29, 2025 15:41
@visr
Copy link
Member

visr commented Jan 29, 2025

This is pushing the link. An edge to the past.

@evetion evetion merged commit 57ad0e1 into main Jan 30, 2025
25 checks passed
@evetion evetion deleted the feat/rename-edge-link branch January 30, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants